From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C682CC169C4 for ; Fri, 8 Feb 2019 21:32:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9318521919 for ; Fri, 8 Feb 2019 21:32:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727182AbfBHVcE (ORCPT ); Fri, 8 Feb 2019 16:32:04 -0500 Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:60648 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726949AbfBHVcE (ORCPT ); Fri, 8 Feb 2019 16:32:04 -0500 Received: from ppp59-167-129-252.static.internode.on.net (HELO dastard) ([59.167.129.252]) by ipmail07.adl2.internode.on.net with ESMTP; 09 Feb 2019 08:02:02 +1030 Received: from dave by dastard with local (Exim 4.80) (envelope-from ) id 1gsDkf-0006Q6-9Y; Sat, 09 Feb 2019 08:32:01 +1100 Date: Sat, 9 Feb 2019 08:32:01 +1100 From: Dave Chinner To: Luis Chamberlain Cc: linux-xfs@vger.kernel.org, gregkh@linuxfoundation.org, Alexander.Levin@microsoft.com, stable@vger.kernel.org, amir73il@gmail.com, hch@infradead.org Subject: Re: [PATCH v2 00/10] xfs: stable fixes for v4.19.y Message-ID: <20190208213201.GP14116@dastard> References: <20190204165427.23607-1-mcgrof@kernel.org> <20190205220655.GF14116@dastard> <20190208194829.GJ11489@garbanzo.do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190208194829.GJ11489@garbanzo.do-not-panic.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Feb 08, 2019 at 11:48:29AM -0800, Luis Chamberlain wrote: > On Wed, Feb 06, 2019 at 09:06:55AM +1100, Dave Chinner wrote: > > On Mon, Feb 04, 2019 at 08:54:17AM -0800, Luis Chamberlain wrote: > > > Kernel stable team, > > > > > > here is a v2 respin of my XFS stable patches for v4.19.y. The only > > > change in this series is adding the upstream commit to the commit log, > > > and I've now also Cc'd stable@vger.kernel.org as well. No other issues > > > were spotted or raised with this series. > > > > > > Reviews, questions, or rants are greatly appreciated. > > > > Test results? > > > > The set of changes look fine themselves, but as always, the proof is > > in the testing... > > I've first established a baseline for v4.19.18 with fstests using > a series of different sections to test against. I annotated the > failures on an expunge list and then use that expunge list to confirm > no regressions -- no failures if we skip the failures already known for > v4.19.18. > > Each different configuration I test against I use a section for. I only > test x86_64 for now but am starting to create a baseline for ppc64le. > > The sections I use: > > * xfs > * xfs_nocrc > * xfs_nocrc_512 > * xfs_reflink > * xfs_reflink_1024 > * xfs_logdev > * xfs_realtimedev Yup, that seems to cover most common things :) > The xfs_logdev and xfs_realtimedev sections use an external log, and as > I have noted before it seems works is needed to rule out an actual > failure. Yeah, there are many tests that don't work properly with external devices, esp. RT devices. That's a less critical area to cover, but it's still good to run it :) Thanks, Luis! -Dave. -- Dave Chinner david@fromorbit.com