From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B89FC282CE for ; Mon, 11 Feb 2019 15:27:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5996221B1A for ; Mon, 11 Feb 2019 15:27:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549898827; bh=NIc8LGoH5F8zK6hU5mL9AlPdAOaDvNdCCpYXmsnhIl0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=aC1ydLF++tpaUW6yg9dhB+lW+qq2daUbq4UZEwdHQtVMfjLsLp624UBsQVZ4NBK/X CNW65+DJNW6MgU52ZXdgIUY7zOMqP3VZhf/8PrOCiaL2h44wTbZGJqG0JcD55U80Bn qsgR7qSWo7h3hCjkaMKWcjdbjSInF0wnATCtUYAc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389839AbfBKO7l (ORCPT ); Mon, 11 Feb 2019 09:59:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:47492 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389833AbfBKO7k (ORCPT ); Mon, 11 Feb 2019 09:59:40 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9EDD9206BA; Mon, 11 Feb 2019 14:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549897180; bh=NIc8LGoH5F8zK6hU5mL9AlPdAOaDvNdCCpYXmsnhIl0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UqdCb4hnqxCE3pjTZNJ8sYNFVcXFu9Q1j1JR4I1KnjBOZpKFwYBRSsq0zl5wPyqZb V+wNELyCf4TBGVVphTlHxUG3M+dvnmxymScUGJdCFgIzfN4Xv8m/E6NVCgebXF9D/t 7XEeIZeSSVcbMD4+qzw1i7nG0uD5yfO2l4sIKrDs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Anatoly Trosinenko , Jan Kara , Sasha Levin Subject: [PATCH 4.14 088/205] udf: Fix BUG on corrupted inode Date: Mon, 11 Feb 2019 15:18:06 +0100 Message-Id: <20190211141834.423012453@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141827.214852402@linuxfoundation.org> References: <20190211141827.214852402@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit d288d95842f1503414b7eebce3773bac3390457e ] When inode is corrupted so that extent type is invalid, some functions (such as udf_truncate_extents()) will just BUG. Check that extent type is valid when loading the inode to memory. Reported-by: Anatoly Trosinenko Signed-off-by: Jan Kara Signed-off-by: Sasha Levin --- fs/udf/inode.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/udf/inode.c b/fs/udf/inode.c index 8dacf4f57414..28b9d7cca29b 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -1357,6 +1357,12 @@ reread: iinfo->i_alloc_type = le16_to_cpu(fe->icbTag.flags) & ICBTAG_FLAG_AD_MASK; + if (iinfo->i_alloc_type != ICBTAG_FLAG_AD_SHORT && + iinfo->i_alloc_type != ICBTAG_FLAG_AD_LONG && + iinfo->i_alloc_type != ICBTAG_FLAG_AD_IN_ICB) { + ret = -EIO; + goto out; + } iinfo->i_unique = 0; iinfo->i_lenEAttr = 0; iinfo->i_lenExtents = 0; -- 2.19.1