From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04236C169C4 for ; Mon, 11 Feb 2019 15:26:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9D7721B26 for ; Mon, 11 Feb 2019 15:26:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549898779; bh=VJiERwK2corbbIoyorsP7SQvjz11GmxcPFu3fFMXhUw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=J1ljXENoN8Bxijdjc4GTUdR6jIXEcxQJhiELXudGy3dPE4Nodih95HL8DjQlDOkct s8cqJm5zgaceJLYbChKfwLGw/fF7N1Vk9+3O4FpvhzcVzpWaQEWCAWHnVdEUNjMa89 IJNZFK78h1v6NsY8lIGia71SldpFCibrKBDXzUYc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390031AbfBKPAl (ORCPT ); Mon, 11 Feb 2019 10:00:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:48568 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389556AbfBKPAi (ORCPT ); Mon, 11 Feb 2019 10:00:38 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C5307206BA; Mon, 11 Feb 2019 15:00:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549897237; bh=VJiERwK2corbbIoyorsP7SQvjz11GmxcPFu3fFMXhUw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t7eRoext6zAxvHu2zFrU/N1TOk7Iu7lcAUG+3NH63vJ9y8SWRvUwPQnpJyiNgWESW AAiXY2DtD+V7zEWn6sgIw3Ro7TV1OjFWU8lxyMhxI9u/m8cCXkEoexo/g1MbrHyZQH 3OKU8EQbpU7imbRVj8Z0nXcQrAHCIFmAJJev3rzI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chris Perl , Anna Schumaker , Sasha Levin Subject: [PATCH 4.14 135/205] NFS: nfs_compare_mount_options always compare auth flavors. Date: Mon, 11 Feb 2019 15:18:53 +0100 Message-Id: <20190211141837.228792921@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141827.214852402@linuxfoundation.org> References: <20190211141827.214852402@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 594d1644cd59447f4fceb592448d5cd09eb09b5e ] This patch removes the check from nfs_compare_mount_options to see if a `sec' option was passed for the current mount before comparing auth flavors and instead just always compares auth flavors. Consider the following scenario: You have a server with the address 192.168.1.1 and two exports /export/a and /export/b. The first export supports `sys' and `krb5' security, the second just `sys'. Assume you start with no mounts from the server. The following results in EIOs being returned as the kernel nfs client incorrectly thinks it can share the underlying `struct nfs_server's: $ mkdir /tmp/{a,b} $ sudo mount -t nfs -o vers=3,sec=krb5 192.168.1.1:/export/a /tmp/a $ sudo mount -t nfs -o vers=3 192.168.1.1:/export/b /tmp/b $ df >/dev/null df: ‘/tmp/b’: Input/output error Signed-off-by: Chris Perl Signed-off-by: Anna Schumaker Signed-off-by: Sasha Levin --- fs/nfs/super.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/nfs/super.c b/fs/nfs/super.c index 38de09b08e96..3c4aeb83e1c4 100644 --- a/fs/nfs/super.c +++ b/fs/nfs/super.c @@ -2401,8 +2401,7 @@ static int nfs_compare_mount_options(const struct super_block *s, const struct n goto Ebusy; if (a->acdirmax != b->acdirmax) goto Ebusy; - if (b->auth_info.flavor_len > 0 && - clnt_a->cl_auth->au_flavor != clnt_b->cl_auth->au_flavor) + if (clnt_a->cl_auth->au_flavor != clnt_b->cl_auth->au_flavor) goto Ebusy; return 1; Ebusy: -- 2.19.1