From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8F53C169C4 for ; Mon, 11 Feb 2019 15:24:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F05D21B1A for ; Mon, 11 Feb 2019 15:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549898656; bh=yYGtJhfy3nt2Ri/Fw8Kxr37YL/vc7onXiCdJnhZ7jhM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1Mk9VDBFa7GJwV4qjY7RICVb5i0ousKcm3Mo4re+5IoOrjkqyBnukw0NfSh6kUtnn 99OmxhSr4v3tbuE7FaSMuTuEL2AqebgAViFWgX+E9BS8evuEvzT4ls7g6PqrUqBkn2 wbIDap5c7qzTVO5rcPyC6O5vr4mYGq0ZUkJNEqg8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390461AbfBKPCn (ORCPT ); Mon, 11 Feb 2019 10:02:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:50958 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390457AbfBKPCm (ORCPT ); Mon, 11 Feb 2019 10:02:42 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CD775222A7; Mon, 11 Feb 2019 15:02:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549897362; bh=yYGtJhfy3nt2Ri/Fw8Kxr37YL/vc7onXiCdJnhZ7jhM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V0aYu6/XJBgQb17ZurWHTXMWdZtGci7q51Qi3PR0gjzc18DESv8XJRtq3BbpKK2AH 1ntMcxz0UHC7ljcVBkFcNsGALcgOaQcYiqe6DaD5PB2T1fkY1AzphedBoa6DbIOWAf o9rcRXo19AeMZtaNkZuRZwq9dnR8PCjACNc8/80E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jann Horn , Miklos Szeredi Subject: [PATCH 4.14 177/205] fuse: call pipe_buf_release() under pipe lock Date: Mon, 11 Feb 2019 15:19:35 +0100 Message-Id: <20190211141839.952223271@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141827.214852402@linuxfoundation.org> References: <20190211141827.214852402@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jann Horn commit 9509941e9c534920ccc4771ae70bd6cbbe79df1c upstream. Some of the pipe_buf_release() handlers seem to assume that the pipe is locked - in particular, anon_pipe_buf_release() accesses pipe->tmp_page without taking any extra locks. From a glance through the callers of pipe_buf_release(), it looks like FUSE is the only one that calls pipe_buf_release() without having the pipe locked. This bug should only lead to a memory leak, nothing terrible. Fixes: dd3bb14f44a6 ("fuse: support splice() writing to fuse device") Cc: stable@vger.kernel.org Signed-off-by: Jann Horn Signed-off-by: Miklos Szeredi Signed-off-by: Greg Kroah-Hartman --- fs/fuse/dev.c | 2 ++ 1 file changed, 2 insertions(+) --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -2024,8 +2024,10 @@ static ssize_t fuse_dev_splice_write(str ret = fuse_dev_do_write(fud, &cs, len); + pipe_lock(pipe); for (idx = 0; idx < nbuf; idx++) pipe_buf_release(pipe, &bufs[idx]); + pipe_unlock(pipe); out: kfree(bufs);