From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3620C169C4 for ; Mon, 11 Feb 2019 15:03:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E217222A7 for ; Mon, 11 Feb 2019 15:03:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549897433; bh=qeqi5773CNN56zaOuH8CTP9AeAVCFgC/MNboz8ODRKQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=J6Ymandmp2cGMT6rTA+mhqY167QJTU4Os6pzsHWSoV/z29PyuXxOk1MpgIY2lfA+f PxQt7mIKCpXd8WPheSJ52c7TlrIVSIKPcgYTBRLW/EIyBEbwghusJDl19NC9O60+5e KY7jKL0ApM+bWr+WOpPD3JtCoMihzRfsAwCnqvcQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389596AbfBKPDw (ORCPT ); Mon, 11 Feb 2019 10:03:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:52600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390720AbfBKPDt (ORCPT ); Mon, 11 Feb 2019 10:03:49 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C72FD222A7; Mon, 11 Feb 2019 15:03:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549897429; bh=qeqi5773CNN56zaOuH8CTP9AeAVCFgC/MNboz8ODRKQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wH+uGULx8X/PdZKo27ABvHUeMcr4bAqzT5PtZo+fkTvQrzssA8igroZ4RLOW4948z ghJqCsSK++4qj9sO6HK4CIunb907ygYK5eGLQ5FuLqzGe+f8BUsUtYqCe97we8xN/m W75CCmMMgBBSTIHeUI5WIPUctijHvyJx0mvOYqCY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Guan Yung Tseng , "KHUENY.Gerhard" , Andy Shevchenko Subject: [PATCH 4.14 201/205] serial: 8250_pci: Make PCI class test non fatal Date: Mon, 11 Feb 2019 15:19:59 +0100 Message-Id: <20190211141841.570503327@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141827.214852402@linuxfoundation.org> References: <20190211141827.214852402@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andy Shevchenko commit 824d17c57b0abbcb9128fb3f7327fae14761914b upstream. As has been reported the National Instruments serial cards have broken PCI class. The commit 7d8905d06405 ("serial: 8250_pci: Enable device after we check black list") made the PCI class check mandatory for the case when device is listed in a quirk list. Make PCI class test non fatal to allow broken card be enumerated. Fixes: 7d8905d06405 ("serial: 8250_pci: Enable device after we check black list") Cc: stable Reported-by: Guan Yung Tseng Tested-by: Guan Yung Tseng Tested-by: KHUENY.Gerhard Signed-off-by: Andy Shevchenko Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/8250/8250_pci.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) --- a/drivers/tty/serial/8250/8250_pci.c +++ b/drivers/tty/serial/8250/8250_pci.c @@ -3425,6 +3425,11 @@ static int serial_pci_guess_board(struct pci_dev *dev, struct pciserial_board *board) { int num_iomem, num_port, first_port = -1, i; + int rc; + + rc = serial_pci_is_class_communication(dev); + if (rc) + return rc; /* * Should we try to make guesses for multiport serial devices later? @@ -3652,10 +3657,6 @@ pciserial_init_one(struct pci_dev *dev, board = &pci_boards[ent->driver_data]; - rc = serial_pci_is_class_communication(dev); - if (rc) - return rc; - rc = serial_pci_is_blacklisted(dev); if (rc) return rc;