From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FE4DC169C4 for ; Mon, 11 Feb 2019 16:07:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 24AC721A80 for ; Mon, 11 Feb 2019 16:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549901235; bh=85M4vKzoAraLamzV51p2zbG1ovry0x2YidPQEyhcgRs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oxRlpVT+Xhco2ukVS6r293zF6S/I38/a82OGbi2RDK90fPg+Y9NOooIRYlxDgbYL5 X4J3sE2/2cQdYbKDUSNdrcRKnehdHyM9J9Ve9OBojVfPNyoecIc2xn1hQkppawmaBW v3sVyh+5fLrtbmVW4stnDg5SLCi/GX+4Cb93X0MY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727068AbfBKO0m (ORCPT ); Mon, 11 Feb 2019 09:26:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:60562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729585AbfBKO0k (ORCPT ); Mon, 11 Feb 2019 09:26:40 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 163EE20844; Mon, 11 Feb 2019 14:26:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549895199; bh=85M4vKzoAraLamzV51p2zbG1ovry0x2YidPQEyhcgRs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uINA61Y3A8ZCBR0ZXGTa3OWxjWlI55QzU02vTmmBiIxslogGJzEs87mS0PSMxE+uM Yq410fGm1kRkPchAqM6wswFjy4LrBqWLAa+5NzvSANSjylMQmAmOMO3R/GRETDTd+w 7XIqA3yO32i2wZARR58ucy5vD8Cscv8fN+G87Q6c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nicholas Mc Guire , Bartosz Golaszewski , Sean Wang , Linus Walleij , Sasha Levin Subject: [PATCH 4.20 127/352] gpio: mt7621: report failure of devm_kasprintf() Date: Mon, 11 Feb 2019 15:15:54 +0100 Message-Id: <20190211141854.449631253@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141846.543045703@linuxfoundation.org> References: <20190211141846.543045703@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 59d646c775d6ae688ee90fda9f2a4270c47b7490 ] kasprintf() may return NULL on failure of internal allocation thus the assigned label is not safe if not explicitly checked. On error mediatek_gpio_bank_probe() returns negative values so -ENOMEM in the (unlikely) failure case should be fine here. Fixes: 4ba9c3afda41 ("gpio: mt7621: Add a driver for MT7621") Signed-off-by: Nicholas Mc Guire Reviewed-by: Bartosz Golaszewski Acked-by: Sean Wang Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/gpio/gpio-mt7621.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/gpio-mt7621.c b/drivers/gpio/gpio-mt7621.c index d72af6f6cdbd..1ec95bc18f5b 100644 --- a/drivers/gpio/gpio-mt7621.c +++ b/drivers/gpio/gpio-mt7621.c @@ -244,6 +244,8 @@ mediatek_gpio_bank_probe(struct device *dev, rg->chip.of_xlate = mediatek_gpio_xlate; rg->chip.label = devm_kasprintf(dev, GFP_KERNEL, "%s-bank%d", dev_name(dev), bank); + if (!rg->chip.label) + return -ENOMEM; ret = devm_gpiochip_add_data(dev, &rg->chip, mtk); if (ret < 0) { -- 2.19.1