From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64C06C169C4 for ; Mon, 11 Feb 2019 14:28:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C50420838 for ; Mon, 11 Feb 2019 14:28:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549895300; bh=52xie6WsGn9BCubo4IoY3gc+/cB0iV7mZ3QvIe5vCFQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vxw++Ws8lPLpUJEWdhUFo5jzAjGcRdACvcu06A7Ku+NS5JylMTUNC0KeUiXtw1AKB iBPDzyarPEXIFznxSo+zMXPvE6k2ghxOLFugHTu3J4d7AeySe+st0qZqJ8z5ZNIVto JkYzKRZgjEx3Md3E4uC4ZxCA3P3ALLzoBgJ5TAIM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729832AbfBKO2S (ORCPT ); Mon, 11 Feb 2019 09:28:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:34204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728966AbfBKO2R (ORCPT ); Mon, 11 Feb 2019 09:28:17 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9247E20821; Mon, 11 Feb 2019 14:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549895297; bh=52xie6WsGn9BCubo4IoY3gc+/cB0iV7mZ3QvIe5vCFQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kBbTsQa3q9m60GMA3EzQAaUCmpZJ21p/FlPm7D0vmiD8WZ3ePAcvgIwf7aNMsU6Qv wzguOnOIQsmyI1mARVpX+sN3Nb0/yvJcDtcNURKvB7PEBjji10AkS3/5RnKgDe4gJm tIwEj6yTl2Mx9IjL6kUdEwLpPAt42Afcy9h6+i78= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Anatoly Trosinenko , Jan Kara , Sasha Levin Subject: [PATCH 4.20 159/352] udf: Fix BUG on corrupted inode Date: Mon, 11 Feb 2019 15:16:26 +0100 Message-Id: <20190211141856.989360193@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141846.543045703@linuxfoundation.org> References: <20190211141846.543045703@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit d288d95842f1503414b7eebce3773bac3390457e ] When inode is corrupted so that extent type is invalid, some functions (such as udf_truncate_extents()) will just BUG. Check that extent type is valid when loading the inode to memory. Reported-by: Anatoly Trosinenko Signed-off-by: Jan Kara Signed-off-by: Sasha Levin --- fs/udf/inode.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/udf/inode.c b/fs/udf/inode.c index 5df554a9f9c9..ae796e10f68b 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c @@ -1357,6 +1357,12 @@ reread: iinfo->i_alloc_type = le16_to_cpu(fe->icbTag.flags) & ICBTAG_FLAG_AD_MASK; + if (iinfo->i_alloc_type != ICBTAG_FLAG_AD_SHORT && + iinfo->i_alloc_type != ICBTAG_FLAG_AD_LONG && + iinfo->i_alloc_type != ICBTAG_FLAG_AD_IN_ICB) { + ret = -EIO; + goto out; + } iinfo->i_unique = 0; iinfo->i_lenEAttr = 0; iinfo->i_lenExtents = 0; -- 2.19.1