From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D0ADC282CE for ; Mon, 11 Feb 2019 15:52:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68E7F21855 for ; Mon, 11 Feb 2019 15:52:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549900326; bh=TBpa5vMs0JrmUz3dafruZ0iVtKGSvh7JN5xZDGADmwQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=shwIbge7Fu/DMwNztPUBUvQ0XZJjViUOXNSHZRlm0yFq6gAcYZZDhMQdwvZrkAZdQ hXp9VXkjyyv+hx7Grsb5Ov6B4bOXLLm5Q0m+CIPSw+/lUvcBDp2vS9BICxnTe5Ysnz wrKuFgxc4svan4W7fDqptfcjinjxNs6VLMuADCR0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731502AbfBKOhj (ORCPT ); Mon, 11 Feb 2019 09:37:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:47094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731495AbfBKOhj (ORCPT ); Mon, 11 Feb 2019 09:37:39 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD7D320700; Mon, 11 Feb 2019 14:37:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549895858; bh=TBpa5vMs0JrmUz3dafruZ0iVtKGSvh7JN5xZDGADmwQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wGGxwqWJvpXHSnQPmJ8Up9oSs2SKkTgvlMQTR1YsXuklxHPoq9o+HYZLAudz6nSmL I+Tq9KrHJBEG8boRJXu8T0at97lgxgFyTvb9JovVKTObNn5YaC+bEeLFTAnuyFYqwj jvcs52MXMbRYXywv29m1XyDUZRivSAnMon6rzl+Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Secunia Research , Marcelo Ricardo Leitner , Neil Horman , "David S. Miller" Subject: [PATCH 4.20 305/352] sctp: walk the list of asoc safely Date: Mon, 11 Feb 2019 15:18:52 +0100 Message-Id: <20190211141906.269528538@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141846.543045703@linuxfoundation.org> References: <20190211141846.543045703@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman [ Upstream commit ba59fb0273076637f0add4311faa990a5eec27c0 ] In sctp_sendmesg(), when walking the list of endpoint associations, the association can be dropped from the list, making the list corrupt. Properly handle this by using list_for_each_entry_safe() Fixes: 4910280503f3 ("sctp: add support for snd flag SCTP_SENDALL process in sendmsg") Reported-by: Secunia Research Tested-by: Secunia Research Signed-off-by: Greg Kroah-Hartman Acked-by: Marcelo Ricardo Leitner Acked-by: Neil Horman Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/sctp/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -2027,7 +2027,7 @@ static int sctp_sendmsg(struct sock *sk, struct sctp_endpoint *ep = sctp_sk(sk)->ep; struct sctp_transport *transport = NULL; struct sctp_sndrcvinfo _sinfo, *sinfo; - struct sctp_association *asoc; + struct sctp_association *asoc, *tmp; struct sctp_cmsgs cmsgs; union sctp_addr *daddr; bool new = false; @@ -2053,7 +2053,7 @@ static int sctp_sendmsg(struct sock *sk, /* SCTP_SENDALL process */ if ((sflags & SCTP_SENDALL) && sctp_style(sk, UDP)) { - list_for_each_entry(asoc, &ep->asocs, asocs) { + list_for_each_entry_safe(asoc, tmp, &ep->asocs, asocs) { err = sctp_sendmsg_check_sflags(asoc, sflags, msg, msg_len); if (err == 0)