From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D35B3C282D7 for ; Mon, 11 Feb 2019 15:52:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A31F521855 for ; Mon, 11 Feb 2019 15:52:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549900372; bh=QTvu3gUAwpeqpFtsPbxDWqgeLMLj4rYqcz1o32CC8Tc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=dm3fma65/GHbFaqQnVpb9//vuQpYTgrSaIq+ZONBw6lTQqzlZzd5Mb0UsE7ZgmZ1S x9+H9T978gXWRI3WfnwUU1H1CI5zUD380Mw9ZBZ3qR9gNoOHkyU8yqYQz3bHMCddDx A3jjFUUr2QL1OQfdbOvXSBRoj1ZDTp0p2qNXfoRc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730888AbfBKOg7 (ORCPT ); Mon, 11 Feb 2019 09:36:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:46274 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731359AbfBKOg7 (ORCPT ); Mon, 11 Feb 2019 09:36:59 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0094B20700; Mon, 11 Feb 2019 14:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549895818; bh=QTvu3gUAwpeqpFtsPbxDWqgeLMLj4rYqcz1o32CC8Tc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EPSvIfwGfwytcCMqb/SGms0BMt6UyUolZ0sea7y9sYCsuAgG2zbw9y4gBTi4ed8QA RxLb3NddPur/dvQY/EaocanpQSlYu3me+3WNXn2AM311jfYSkVuKkGsvqaQdUjkZu9 wXmmjwvlMJjyTbfYacSsJ8wBV4Zi2jA395jUGE5o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Gustavo A. R. Silva" , Felipe Balbi Subject: [PATCH 4.20 333/352] usb: gadget: udc: net2272: Fix bitwise and boolean operations Date: Mon, 11 Feb 2019 15:19:20 +0100 Message-Id: <20190211141908.151766078@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141846.543045703@linuxfoundation.org> References: <20190211141846.543045703@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gustavo A. R. Silva commit 07c69f1148da7de3978686d3af9263325d9d60bd upstream. (!x & y) strikes again. Fix bitwise and boolean operations by enclosing the expression: intcsr & (1 << NET2272_PCI_IRQ) in parentheses, before applying the boolean operator '!'. Notice that this code has been there since 2011. So, it would be helpful if someone can double-check this. This issue was detected with the help of Coccinelle. Fixes: ceb80363b2ec ("USB: net2272: driver for PLX NET2272 USB device controller") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva Signed-off-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/net2272.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/gadget/udc/net2272.c +++ b/drivers/usb/gadget/udc/net2272.c @@ -2083,7 +2083,7 @@ static irqreturn_t net2272_irq(int irq, #if defined(PLX_PCI_RDK2) /* see if PCI int for us by checking irqstat */ intcsr = readl(dev->rdk2.fpga_base_addr + RDK2_IRQSTAT); - if (!intcsr & (1 << NET2272_PCI_IRQ)) { + if (!(intcsr & (1 << NET2272_PCI_IRQ))) { spin_unlock(&dev->lock); return IRQ_NONE; }