From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B5BEC169C4 for ; Mon, 11 Feb 2019 15:36:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20285222A5 for ; Mon, 11 Feb 2019 15:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549899406; bh=70VXdcusYD7QdP60gA3nNRgQRpSLmSMVV5xhabnpmbg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=DdH3VPUDHoeNHL1c7vUl554hudiZLGQrxSxNRzH3FWL4Syw29OyWGpTc12vE37TvV 1mLBwn1B3sp0GCskwZXu+cnyggd4kZu8Ylg55ut1gN7HdQKaAAMvdYvZkNjnXl/UkQ niJvADZQPm1gU0TaCXSL9COYrdn+uSQFOzWkV2oI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388289AbfBKOvg (ORCPT ); Mon, 11 Feb 2019 09:51:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:37686 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387849AbfBKOvf (ORCPT ); Mon, 11 Feb 2019 09:51:35 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 11AB620844; Mon, 11 Feb 2019 14:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549896694; bh=70VXdcusYD7QdP60gA3nNRgQRpSLmSMVV5xhabnpmbg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EvbqD4isZWnA7X7zCU/bxJbP1YvekpYA81ZKWwOKkLpD9T/L8svYT00qRSdpjfCsF ove8ig/UmS+kUlYmY81S7tCbWErYpwwYM2NVvNIkB0v3mty2uzfrgtbwmkWJvkqNa+ old41uN1c65HBSM3/vZZcuaFzCtNdXVyq+21KOWg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Russell King , Yonglong Liu , "David S. Miller" Subject: [PATCH 4.19 270/313] Revert "net: phy: marvell: avoid pause mode on SGMII-to-Copper for 88e151x" Date: Mon, 11 Feb 2019 15:19:10 +0100 Message-Id: <20190211141911.336766246@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190211141852.749630980@linuxfoundation.org> References: <20190211141852.749630980@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Russell King [ Upstream commit c14f07c6211cc01d52ed92cce1fade5071b8d197 ] This reverts commit 6623c0fba10ef45b64ca213ad5dec926f37fa9a0. The original diagnosis was incorrect: it appears that the NIC had PHY polling mode enabled, which meant that it overwrote the PHYs advertisement register during negotiation. Signed-off-by: Russell King Tested-by: Yonglong Liu Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/phy/marvell.c | 12 ------------ 1 file changed, 12 deletions(-) --- a/drivers/net/phy/marvell.c +++ b/drivers/net/phy/marvell.c @@ -868,8 +868,6 @@ static int m88e1510_config_init(struct p /* SGMII-to-Copper mode initialization */ if (phydev->interface == PHY_INTERFACE_MODE_SGMII) { - u32 pause; - /* Select page 18 */ err = marvell_set_page(phydev, 18); if (err < 0) @@ -892,16 +890,6 @@ static int m88e1510_config_init(struct p err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE); if (err < 0) return err; - - /* There appears to be a bug in the 88e1512 when used in - * SGMII to copper mode, where the AN advertisement register - * clears the pause bits each time a negotiation occurs. - * This means we can never be truely sure what was advertised, - * so disable Pause support. - */ - pause = SUPPORTED_Pause | SUPPORTED_Asym_Pause; - phydev->supported &= ~pause; - phydev->advertising &= ~pause; } return m88e1318_config_init(phydev);