From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88821C10F03 for ; Fri, 22 Mar 2019 11:19:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5A45221929 for ; Fri, 22 Mar 2019 11:19:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553253580; bh=MCD62IVRJOeVzwt0ZctsXDm4Oen2gi0e5BjzhuUKlt0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=q2xaIvaozpyopmnDNO764hqk0I1Y8KQPXA5G6O4pkesezvi58YbRvhcwlJ75ES9+w 65wFUSL/FUCfkndhmwpO659308Uoe5+h97+tSy8H6G4JO9GIZzkZtmJnsLVfVNDCMZ 4H2ntCBQL8ORJjZy8EcCRfPfKKUL3ZDDzB+KeO4o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728186AbfCVLTj (ORCPT ); Fri, 22 Mar 2019 07:19:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:46078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726667AbfCVLTi (ORCPT ); Fri, 22 Mar 2019 07:19:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A83C52190A; Fri, 22 Mar 2019 11:19:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553253578; bh=MCD62IVRJOeVzwt0ZctsXDm4Oen2gi0e5BjzhuUKlt0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ESBWXA79q41aAeaN4dVWFN5TugqAhIqHm8ryUVwOI1H2c7ZsM/0z8s/uifY6upPnK e6zAQxTGbnvSknr872jR1TYH0OFUAllg6vgOBeyFDcUTY0awTytZqaC1JcIVUR4dhF 4zZdByqtXVJk0FB0wGI8zRsAsv4JPQwr+OSfuX9g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, YueHaibing , Manish Rangankar , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 3.18 011/134] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param Date: Fri, 22 Mar 2019 12:13:44 +0100 Message-Id: <20190322111210.942859405@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111210.465931067@linuxfoundation.org> References: <20190322111210.465931067@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 72b4a0465f995175a2e22cf4a636bf781f1f28a7 ] The return code should be check while qla4xxx_copy_from_fwddb_param fails. Signed-off-by: YueHaibing Acked-by: Manish Rangankar Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla4xxx/ql4_os.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index d0cad6fc598e1..a9fac1eb8306a 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -7251,6 +7251,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct scsi_qla_host *ha, rc = qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn, fw_ddb_entry); + if (rc) + goto free_sess; ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n", __func__, fnode_sess->dev.kobj.name); -- 2.19.1