From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12243C43381 for ; Fri, 22 Mar 2019 13:02:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB6B62075E for ; Fri, 22 Mar 2019 13:02:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553259752; bh=744JxqBwaEhaygF1yOYBo0xHvXf/+TfxpPNWUjhhD68=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=x7KAw4uXxrULqkv66flLKyBuSgeG7AiWIUQYdk4TxxyHLIlZ+vxqPF2gOU8PLFY8r TYWZVmgWlynQ7dSuUoJjmZqPttr+mJDYiibNKth3pGaRoLkXg/fuuKHv9mjLRVPU3K VrsMq68EMU2xzrmwfhPP4xKRX4GYrtXcBkDBCp44= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728970AbfCVLlo (ORCPT ); Fri, 22 Mar 2019 07:41:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:43940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728784AbfCVLlo (ORCPT ); Fri, 22 Mar 2019 07:41:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE95221929; Fri, 22 Mar 2019 11:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553254903; bh=744JxqBwaEhaygF1yOYBo0xHvXf/+TfxpPNWUjhhD68=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ie68v6YoB2wDah1fKdBnVJQMiVAHZ1PtG7erY62NQhIBYRKn4mNdDkcEfMM/xNRq4 jFxiXplADymRodm+jY1ExCvDy5N4U7eT1OKv3+AOeobg12g1/CraOVzGybZctMeX9I TgQMt/2L955vh2dWjjbPjErUeJMM/EKI17X62K6w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Huang Zijiang , "David S. Miller" , Sasha Levin Subject: [PATCH 4.9 018/118] net: hns: Fix object reference leaks in hns_dsaf_roce_reset() Date: Fri, 22 Mar 2019 12:14:50 +0100 Message-Id: <20190322111217.287330289@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111215.873964544@linuxfoundation.org> References: <20190322111215.873964544@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit c969c6e7ab8cb42b5c787c567615474fdbad9d6a ] The of_find_device_by_node() takes a reference to the underlying device structure, we should release that reference. Signed-off-by: Huang Zijiang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c index 5bb019d49409..551b2a9ebf0f 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c @@ -2820,6 +2820,7 @@ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset) dsaf_dev = dev_get_drvdata(&pdev->dev); if (!dsaf_dev) { dev_err(&pdev->dev, "dsaf_dev is NULL\n"); + put_device(&pdev->dev); return -ENODEV; } @@ -2827,6 +2828,7 @@ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset) if (AE_IS_VER1(dsaf_dev->dsaf_ver)) { dev_err(dsaf_dev->dev, "%s v1 chip doesn't support RoCE!\n", dsaf_dev->ae_dev.name); + put_device(&pdev->dev); return -ENODEV; } -- 2.19.1