From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB0A7C43381 for ; Tue, 26 Mar 2019 07:32:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C12CF2070B for ; Tue, 26 Mar 2019 07:32:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730829AbfCZHct (ORCPT ); Tue, 26 Mar 2019 03:32:49 -0400 Received: from verein.lst.de ([213.95.11.211]:34692 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbfCZHcs (ORCPT ); Tue, 26 Mar 2019 03:32:48 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 2ECC968C4E; Tue, 26 Mar 2019 08:32:40 +0100 (CET) Date: Tue, 26 Mar 2019 08:32:39 +0100 From: Christoph Hellwig To: Ming Lei Cc: Sagi Grimberg , Christoph Hellwig , linux-nvme@lists.infradead.org, Yi Zhang , stable@vger.kernel.org, Chaitanya Kulkarni Subject: Re: [PATCH 1/2] nvme: target: fix nvmet_file_init_bvec() Message-ID: <20190326073239.GA21571@lst.de> References: <20190325100708.24172-1-ming.lei@redhat.com> <20190325100708.24172-2-ming.lei@redhat.com> <20190325105231.GA24907@lst.de> <20190326013935.GC30669@ming.t460p> <20190326021627.GE30669@ming.t460p> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190326021627.GE30669@ming.t460p> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Mar 26, 2019 at 10:16:28AM +0800, Ming Lei wrote: > Also there is the same issue for block device backed target. > > If no one objects, I'd like to take the approach of adjusting segment > boundary mask. Just go for the merge of your two patches. That fixes the issue and actually makes the code simpler.