From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C72C0C10F0E for ; Mon, 15 Apr 2019 19:29:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8DF2A20818 for ; Mon, 15 Apr 2019 19:29:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555356551; bh=vKgfG1AmS+te3HdJREXVT6S4yM3AS8G45p75f6/j1A8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rmKr0Y7yJI8vl9RDvxTeO7Us4y42H/knW+axtb5hCM/Hvozm9vSG1TIqyB/wYz0pO t7KCu4srihsfTZ2aH6a2N72rRj183rWkZte5AQX1WYZuqfS44k/I1W+uSMBF6RGu/3 DPxpQtmpQQLzxmpbcio2dPWlAPwCe1VRgfCcVAvg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728957AbfDOTCp (ORCPT ); Mon, 15 Apr 2019 15:02:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:33794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728826AbfDOTCj (ORCPT ); Mon, 15 Apr 2019 15:02:39 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D93D2087C; Mon, 15 Apr 2019 19:02:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555354958; bh=vKgfG1AmS+te3HdJREXVT6S4yM3AS8G45p75f6/j1A8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EAnKZDqbIjwI87Szmk67khSiUe3O9Na/jrYabkH7bqPmoFu7HeCXpsUh64kJW7XEX MdxQ0jZTCAPbxmdaMtiCAqDaNqiw6rrxPy8L/y3KWPYLac/p9cTaUAjvCJmiI/DSdt O7eyg0drb1y5P+JMoTHt+zCXMqHS5OiVbZGmIuV8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jann Horn , Linus Torvalds Subject: [PATCH 4.14 14/69] tty: mark Siemens R3964 line discipline as BROKEN Date: Mon, 15 Apr 2019 20:58:32 +0200 Message-Id: <20190415183729.513873058@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190415183726.036654568@linuxfoundation.org> References: <20190415183726.036654568@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Greg Kroah-Hartman commit c7084edc3f6d67750f50d4183134c4fb5712a5c8 upstream. The n_r3964 line discipline driver was written in a different time, when SMP machines were rare, and users were trusted to do the right thing. Since then, the world has moved on but not this code, it has stayed rooted in the past with its lovely hand-crafted list structures and loads of "interesting" race conditions all over the place. After attempting to clean up most of the issues, I just gave up and am now marking the driver as BROKEN so that hopefully someone who has this hardware will show up out of the woodwork (I know you are out there!) and will help with debugging a raft of changes that I had laying around for the code, but was too afraid to commit as odds are they would break things. Many thanks to Jann and Linus for pointing out the initial problems in this codebase, as well as many reviews of my attempts to fix the issues. It was a case of whack-a-mole, and as you can see, the mole won. Reported-by: Jann Horn Signed-off-by: Greg Kroah-Hartman Signed-off-by: Linus Torvalds --- drivers/char/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/char/Kconfig +++ b/drivers/char/Kconfig @@ -380,7 +380,7 @@ config XILINX_HWICAP config R3964 tristate "Siemens R3964 line discipline" - depends on TTY + depends on TTY && BROKEN ---help--- This driver allows synchronous communication with devices using the Siemens R3964 packet protocol. Unless you are dealing with special