From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A7F8C10F11 for ; Mon, 22 Apr 2019 20:11:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0CC82064A for ; Mon, 22 Apr 2019 20:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555963883; bh=XAzFXlP87E7U02nFKK6K6OOe5SvtJALvL1QYzYr23jo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=levBhXTtXccoOEG0tjC8dEcvPqzQr0s1MP//qPlroCrdkz+JTB0T6zEHq5xMqpqKt nF1TsJg4etutscrPdUaq+rMNM75eYtUVxuiFyjZXWD5G/0mJwbc0SJVb6adPEqYxa1 Yw9F1V46Sg6jyWHu6yM5d6f/dX1X4dhTjHMUhsAg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728736AbfDVTmS (ORCPT ); Mon, 22 Apr 2019 15:42:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:42654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728619AbfDVTmR (ORCPT ); Mon, 22 Apr 2019 15:42:17 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7A3CA214AE; Mon, 22 Apr 2019 19:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555962137; bh=XAzFXlP87E7U02nFKK6K6OOe5SvtJALvL1QYzYr23jo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hPyrnPFrkFyRyOXhy/MlmO52ql87pym+yF17KcDhvub2ELWgCPP4L599Qeojz2Cvh E92YAb/z5V0M0Oh4BN63gH3x8L/13sEfZEffu5bR+p461VchslzYLW5/ttvZYxoDIc L8fcvN0gh79cfdldoR4BXLtAkiTcsp0vejf2Zcrs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Aditya Pakki , "David S . Miller" , Sasha Levin Subject: [PATCH AUTOSEL 5.0 12/98] qlcnic: Avoid potential NULL pointer dereference Date: Mon, 22 Apr 2019 15:40:39 -0400 Message-Id: <20190422194205.10404-12-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190422194205.10404-1-sashal@kernel.org> References: <20190422194205.10404-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Aditya Pakki [ Upstream commit 5bf7295fe34a5251b1d241b9736af4697b590670 ] netdev_alloc_skb can fail and return a NULL pointer which is dereferenced without a check. The patch avoids such a scenario. Signed-off-by: Aditya Pakki Signed-off-by: David S. Miller Signed-off-by: Sasha Levin (Microsoft) --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c index 3b0adda7cc9c..a4cd6f2cfb86 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c @@ -1048,6 +1048,8 @@ int qlcnic_do_lb_test(struct qlcnic_adapter *adapter, u8 mode) for (i = 0; i < QLCNIC_NUM_ILB_PKT; i++) { skb = netdev_alloc_skb(adapter->netdev, QLCNIC_ILB_PKT_SIZE); + if (!skb) + break; qlcnic_create_loopback_buff(skb->data, adapter->mac_addr); skb_put(skb, QLCNIC_ILB_PKT_SIZE); adapter->ahw->diag_cnt = 0; -- 2.19.1