From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A344C04AA7 for ; Wed, 15 May 2019 04:57:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 446B020862 for ; Wed, 15 May 2019 04:57:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557896236; bh=3zRyvWEiloPg/6g3Sltz36heTPMDdlNYexVj2wJeyTU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ePQN38souFfySjZtTAwNCZ6e4hB3y4UCiHAz+kTOyPNU41ZBgm8jpdql1ldzyRz39 H/1dOjEVqgHp+EXDTHbnbAxSnCOCmNDfIHdw0zHo+KCLuvdDWJUJQWe1HMhuaspHJk ZyETmUa7RfMl8TDgCK4IwlxRnFp21Y/kzifKf08Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725877AbfEOE5P (ORCPT ); Wed, 15 May 2019 00:57:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:38298 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbfEOE5P (ORCPT ); Wed, 15 May 2019 00:57:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6783F20862; Wed, 15 May 2019 04:57:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557896234; bh=3zRyvWEiloPg/6g3Sltz36heTPMDdlNYexVj2wJeyTU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aeWNp4d9UTdbzDEeN+3D+koBzSHjEdcdblK4rpQYtX42uf/DP8leBU7QH8nNs4pYd b7vRfIksXJTCIV3iMz+6p7f9YmCrTaYBisTh93vRETSqEIR+eYHN+CWv9hbqKF5HEk e1SCGUrIA9JCcPzhOL17th3OXYDK6dNaLndfGwiU= Date: Wed, 15 May 2019 06:57:11 +0200 From: Greg Kroah-Hartman To: "Schmauss, Erik" Cc: Paul Gortmaker , "Wysocki, Rafael J" , "stable@vger.kernel.org" Subject: Re: Possible mis-backport of 4abb951b in 4.19.35 ("ACPICA: AML interpreter: add region addresses...") Message-ID: <20190515045711.GA16452@kroah.com> References: <20190505194448.GA2649@windriver.com> <20190506084145.GA23991@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, May 15, 2019 at 01:17:28AM +0000, Schmauss, Erik wrote: > > > > -----Original Message----- > > From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] > > Sent: Monday, May 6, 2019 1:42 AM > > To: Paul Gortmaker ; Wysocki, Rafael J > > > > Cc: stable@vger.kernel.org; Schmauss, Erik > > Subject: Re: Possible mis-backport of 4abb951b in 4.19.35 ("ACPICA: AML > > interpreter: add region addresses...") > > > > On Sun, May 05, 2019 at 03:44:48PM -0400, Paul Gortmaker wrote: > > > I noticed 4.19.35 got a backport of mainline 4abb951b, but it appears > > > to be a duplicate backport that landed in the wrong function. We can > > > see this in the stable-queue repo: > > > > > > stable-queue$ find . -name '*acpica-aml-interpreter-add-region-addr*' > > > |grep 4.19 > > > ./releases/4.19.6/acpica-aml-interpreter-add-region-addresses-in-globa > > > l-list-during-initialization.patch > > > ./releases/4.19.3/revert-acpica-aml-interpreter-add-region-addresses-i > > > n.patch > > > ./releases/4.19.35/acpica-aml-interpreter-add-region-addresses-in-glob > > > al-list-during-initialization.patch > > > ./releases/4.19.2/acpica-aml-interpreter-add-region-addresses-in-globa > > > l-list-during-initialization.patch > > > > > > So it was added to 4.19.2, reverted in .3, re-added in .6, and then > > > finally patched into a similar looking but wrong function in .35 > > > > > > If we diff the .6 and .35 versions, we see the function difference: > > > > > > -@@ -417,6 +417,10 @@ acpi_ds_eval_region_operands(struct acpi > > > +@@ -523,6 +523,10 @@ acpi_ds_eval_table_region_operands(struc > > > > > > I don't know what the history is/was around the 2/3/6 churn, but the > > > re-addition in 4.19.35 to a different function sure looks wrong. > > > > > > The commit adds a call "status = acpi_ut_add_address_range(..." and if > > > we check mainline, there is only one in that file, but in 4.19.35+ > > > there now are two calls - since the two functions had similar context > > > and comments, it isn't hard to see how patch could/would apply it a > > > 2nd time in the wrong place. > > > > > > I didn't check if any of the other currently maintained linux-stable > > > versions also had this possible issue. > > > > > > Hi Greg, > > > Ugh, Rafael, did I mess this up again? Can you check to see if I need to fix this > > somehow? > > It should be called in acpi_ds_eval_region_operands rather than acpi_ds_eval_table_region_operands. > Please remove the call from acpi_ds_eval_table_region_operands. Great, can someone please send me a patch for this so that I don't get it wrong myself? thanks, greg k-h