From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B96F8C04AAF for ; Tue, 21 May 2019 17:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 812B1217D9 for ; Tue, 21 May 2019 17:23:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="b+/W6d2W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728271AbfEURW7 (ORCPT ); Tue, 21 May 2019 13:22:59 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:46932 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728114AbfEURW7 (ORCPT ); Tue, 21 May 2019 13:22:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=F6hzvh3Jla0WhoTxfizl6fXxrFIMr5UOMU03ImxH5Ac=; b=b+/W6d2WiUF/OIvuwtkfb/SkH /3+H3kA7ADfToOu3edm4BJ3fw83zXGvUfTGn1nWi+7xh+UsRyQzwtjc5D7TE5KH0Yxdt2+Ntb1JuT k+UkYrfqVygj7Ya7vRRjZeMSv7/0B8vELoNfEcC5S6znYc0nJZ45UQ6g/RrdMF3atTmuXQGLIkUeL FSIJnnHuCkxK5wpUfYxJ4YtgoLzHO7WvKGn80nF/J8dK81cS52b2JeWuhIINVflNpYjn/gopPVt7r 8wdidUGKN9XC0VtidvYMf7NIFF+tcNRHEnIFVJhWN8Eu0WFbjrUqmsi1Oyaz1Ie9gtNMgjKTgf+JY xAmvcaRsw==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT8Ta-0002Ug-G4; Tue, 21 May 2019 17:22:58 +0000 Date: Tue, 21 May 2019 10:22:58 -0700 From: Christoph Hellwig To: Guilherme Piccoli Cc: Christoph Hellwig , linux-block@vger.kernel.org, linux-raid , dm-devel@redhat.com, axboe@kernel.dk, Gavin Guo , Jay Vosburgh , "Guilherme G. Piccoli" , Ming Lei , Song Liu , Tetsuo Handa , stable@vger.kernel.org Subject: Re: [PATCH V2 2/2] md/raid0: Do not bypass blocking queue entered for raid0 bios Message-ID: <20190521172258.GA32702@infradead.org> References: <20190520220911.25192-1-gpiccoli@canonical.com> <20190520220911.25192-2-gpiccoli@canonical.com> <20190521125634.GB16799@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, May 21, 2019 at 11:10:05AM -0300, Guilherme Piccoli wrote: > Hi Christoph, thanks for looking into this. > You're right, this series fixes both issues. The problem I see though > is that it relies > on legacy IO path removal - for v5.0 and beyond, all fine. But > backporting that to > v4.17-v4.20 stable series will be quite painful. > > My fixes are mostly "oneliners". If we could get both approaches upstream, > that'd be perfect! But they basically just fix code that otherwise gets removed. And the way this patches uses the ENTERED flag from the md code looks slightly sketchy to me. Maybe we want them as stable only patches.