From: Eric Wong <e@80x24.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Deepa Dinamani <deepa.kernel@gmail.com>,
linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk,
arnd@arndb.de, dbueso@suse.de, axboe@kernel.dk,
dave@stgolabs.net, jbaron@akamai.com,
linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
omar.kilani@gmail.com, tglx@linutronix.de,
stable@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH 1/1] signal: Adjust error codes according to restore_user_sigmask()
Date: Tue, 21 May 2019 23:33:19 +0000 [thread overview]
Message-ID: <20190521233319.GA17957@dcvr> (raw)
In-Reply-To: <20190521152748.6b4cd70cf83a1183caa6aae7@linux-foundation.org>
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 21 May 2019 09:25:51 +0000 Eric Wong <e@80x24.org> wrote:
>
> > Deepa Dinamani <deepa.kernel@gmail.com> wrote:
> > > For all the syscalls that receive a sigmask from the userland,
> > > the user sigmask is to be in effect through the syscall execution.
> > > At the end of syscall, sigmask of the current process is restored
> > > to what it was before the switch over to user sigmask.
> > > But, for this to be true in practice, the sigmask should be restored
> > > only at the the point we change the saved_sigmask. Anything before
> > > that loses signals. And, anything after is just pointless as the
> > > signal is already lost by restoring the sigmask.
> > >
> > > The inherent issue was detected because of a regression caused by
> > > 854a6ed56839a.
> > > The patch moved the signal_pending() check closer to restoring of the
> > > user sigmask. But, it failed to update the error code accordingly.
> > >
> > > Detailed issue discussion permalink:
> > > https://lore.kernel.org/linux-fsdevel/20190427093319.sgicqik2oqkez3wk@dcvr/
> > >
> > > Note that the patch returns interrupted errors (EINTR, ERESTARTNOHAND,
> > > etc) only when there is no other error. If there is a signal and an error
> > > like EINVAL, the syscalls return -EINVAL rather than the interrupted
> > > error codes.
> > >
> > > The sys_io_uring_enter() seems to be returning success when there is
> > > a signal and the queue is not empty. This seems to be a bug. I will
> > > follow up with a separate patch for that.
> > >
> > > Reported-by: Eric Wong <e@80x24.org>
> > > Fixes: 854a6ed56839a40f6b5d02a2962f48841482eec4 ("signal: Add restore_user_sigmask()")
> > > Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> > > Reviewed-by: Davidlohr Bueso <dbueso@suse.de>
>
> (top-posting fixed).
>
> > It's been 2 weeks and this fix hasn't appeared in mmots / mmotm.
> > I also noticed it's missing Cc: for stable@ (below)
>
> Why is a -stable backport needed? I see some talk above about lost
> signals but it is unclear whether these are being observed after fixing
> the regression caused by 854a6ed56839a.
I guess Deepa's commit messages wasn't clear...
I suggest prepending this as the first paragraph to Deepa's
original message:
This fixes a bug introduced with 854a6ed56839a which caused
EINTR to not be reported to userspace on epoll_pwait. Failure
to report EINTR to userspace caused problems with user code
which relies on EINTR to run signal handlers.
> IOW, can we please have a changelog which has a clear and complete
> description of the user-visible effects of the change.
>
> And please Cc Oleg.
next prev parent reply other threads:[~2019-05-21 23:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190507043954.9020-1-deepa.kernel@gmail.com>
2019-05-21 9:25 ` [PATCH 1/1] signal: Adjust error codes according to restore_user_sigmask() Eric Wong
2019-05-21 22:27 ` Andrew Morton
2019-05-21 23:33 ` Eric Wong [this message]
2019-05-22 0:35 ` Deepa Dinamani
2019-05-22 0:44 ` Deepa Dinamani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521233319.GA17957@dcvr \
--to=e@80x24.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=deepa.kernel@gmail.com \
--cc=jbaron@akamai.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=omar.kilani@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).