From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23440C282CE for ; Wed, 22 May 2019 19:28:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1C7920675 for ; Wed, 22 May 2019 19:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558553289; bh=DAQbjq52qcjt0fmV+XrBFXarb+DXrDg4uq76KyBSLSE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vlNoe3q7ayY5ovRfAvhAfE1bO4RoOre3Un/mn95sTwVyf5BjEYPvjCEUN+yIon97A CHxea+xI35HnrpT1XvoLWsYtPaJ0A6ff1qaeD4sHMoud9B49lceyH7j782d+5AQEVV BzbsOfioWoh8njt0mL151jO/bYfoqogw05rJAmf4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731999AbfEVT2H (ORCPT ); Wed, 22 May 2019 15:28:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:50672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731995AbfEVT2H (ORCPT ); Wed, 22 May 2019 15:28:07 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D032421841; Wed, 22 May 2019 19:28:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558553286; bh=DAQbjq52qcjt0fmV+XrBFXarb+DXrDg4uq76KyBSLSE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E1DWe3hAxiJuNX/fA6AFR4T8EwYs0xG+TPvb+JYphx+zaFlq+48obwyqU2U7xBja+ i4Age4aLpfwVYlsLdkQBK8w4ah98Nc75Wb6bIRV+kn840MS1u92aCDZZzrObwTj0VP vbTUtrxFIf4FqP2yZYRQ8gUfjSYN5GD+VuO/Rr+M= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kangjie Lu , Kalle Valo , Sasha Levin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 060/244] net: cw1200: fix a NULL pointer dereference Date: Wed, 22 May 2019 15:23:26 -0400 Message-Id: <20190522192630.24917-60-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190522192630.24917-1-sashal@kernel.org> References: <20190522192630.24917-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Kangjie Lu [ Upstream commit 0ed2a005347400500a39ea7c7318f1fea57fb3ca ] In case create_singlethread_workqueue fails, the fix free the hardware and returns NULL to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/st/cw1200/main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/st/cw1200/main.c b/drivers/net/wireless/st/cw1200/main.c index 90dc979f260b6..c1608f0bf6d01 100644 --- a/drivers/net/wireless/st/cw1200/main.c +++ b/drivers/net/wireless/st/cw1200/main.c @@ -345,6 +345,11 @@ static struct ieee80211_hw *cw1200_init_common(const u8 *macaddr, mutex_init(&priv->wsm_cmd_mux); mutex_init(&priv->conf_mutex); priv->workqueue = create_singlethread_workqueue("cw1200_wq"); + if (!priv->workqueue) { + ieee80211_free_hw(hw); + return NULL; + } + sema_init(&priv->scan.lock, 1); INIT_WORK(&priv->scan.work, cw1200_scan_work); INIT_DELAYED_WORK(&priv->scan.probe_work, cw1200_probe_work); -- 2.20.1