From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78D44C04AAC for ; Thu, 23 May 2019 05:41:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3FD022175B for ; Thu, 23 May 2019 05:41:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558590089; bh=rTm2QtayXzOcfjOZGDcaeMQ6Xk5vWjYR34rnIomr6hQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kAE0o44XZBM51wg+kfIjRnglXTXwjeZ+y/4+ZV3IuSfmIwCv5AAMLMdXApYlwx2A+ mBr7rqWRsJHyj6Gs0mUOI2zjZnHzZ9UxdmqtE7C+ZkN047s4QJrMmffMHr7ZNpxBFX mcoKxKfmfOSg23mKn5TD8NUSmIaPOrb/lYH5+UjA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726081AbfEWFl2 (ORCPT ); Thu, 23 May 2019 01:41:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:41286 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725806AbfEWFl2 (ORCPT ); Thu, 23 May 2019 01:41:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F7F821019; Thu, 23 May 2019 05:41:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558590088; bh=rTm2QtayXzOcfjOZGDcaeMQ6Xk5vWjYR34rnIomr6hQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2C2YpKVT+7vclYNs9eGQ+yTBkPooawhkUsGQ9g8TxIwc43XcRJX1idnfMXNvD3im3 jLg6fzuA5eQ0OpYvfWbUWXdUxaiDJYDTLg2iXURniZA+ZuPUoZjmpKw7T42RJSNQ/k dipRY2xmKM43FAG7LusZe2RuZXIzvm5cfsl3q6u8= Date: Thu, 23 May 2019 07:41:25 +0200 From: Greg Kroah-Hartman To: Justin Forbes Cc: LKML , stable@vger.kernel.org, Martin Schwidefsky Subject: Re: [PATCH 5.0 119/123] s390/mm: convert to the generic get_user_pages_fast code Message-ID: <20190523054125.GB16130@kroah.com> References: <20190520115245.439864225@linuxfoundation.org> <20190520115253.074303494@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, May 22, 2019 at 04:46:16PM -0500, Justin Forbes wrote: > On Mon, May 20, 2019 at 7:30 AM Greg Kroah-Hartman > wrote: > > > > From: Martin Schwidefsky > > > > commit 1a42010cdc26bb7e5912984f3c91b8c6d55f089a upstream. > > > > Define the gup_fast_permitted to check against the asce_limit of the > > mm attached to the current task, then replace the s390 specific gup > > code with the generic implementation in mm/gup.c. > > > > Signed-off-by: Martin Schwidefsky > > Signed-off-by: Greg Kroah-Hartman > > While this code seems to work fine upstream, when backported to 5.0 it > fails to build: > > BUILDSTDERR: In file included from ./include/linux/mm.h:98, > BUILDSTDERR: from mm/gup.c:6: > BUILDSTDERR: mm/gup.c: In function '__get_user_pages_fast': > BUILDSTDERR: ./arch/s390/include/asm/pgtable.h:1277:28: error: too > many arguments to function 'gup_fast_permitted' > BUILDSTDERR: #define gup_fast_permitted gup_fast_permitted > BUILDSTDERR: ^~~~~~~~~~~~~~~~~~ > BUILDSTDERR: mm/gup.c:1856:6: note: in expansion of macro 'gup_fast_permitted' > BUILDSTDERR: if (gup_fast_permitted(start, nr_pages, write)) { > > It is missing upstream commit ad8cfb9c42ef83ecf4079bc7d77e6557648e952b > mm/gup: Remove the 'write' parameter from gup_fast_permitted() Oops, thanks for catching this. I'll go queue this patch up now. greg k-h