From: Nathan Chancellor <natechancellor@gmail.com>
To: Joe Korty <Joe.Korty@concurrent-rt.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Alistair Strachan <astrachan@google.com>,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com
Subject: Re: [BUG 4.4.178] x86_64 compat mode futexes broken
Date: Thu, 6 Jun 2019 16:11:30 -0700 [thread overview]
Message-ID: <20190606231130.GA69331@archlinux-epyc> (raw)
In-Reply-To: <20190606211140.GA52454@zipoli.concurrent-rt.com>
On Thu, Jun 06, 2019 at 09:11:43PM +0000, Joe Korty wrote:
> Starting with 4.4.178, the LTP test
>
> pthread_cond_wait/2-3
>
> when compiled on x86_64 with 'gcc -m32', started failing. It generates this log output:
>
> [16:18:38]Implementation supports the MONOTONIC CLOCK but option is disabled in test.
> [16:18:38]Test starting
> [16:18:38] Process-shared primitive will be tested
> [16:18:38] Alternative clock for cond will be tested
> [16:18:38]Test 2-3.c FAILED: The child did not own the mutex inside the cleanup handler
>
What is the exact build command + test case command? I'd like to
reproduce this myself.
> A git bisection between 4.4.177..178 shows that this commit is the culprit:
>
> Git-Commit: 79739ad2d0ac5787a15a1acf7caaf34cd95bbf3c
> Author: Alistair Strachan <astrachan@google.com>
> Subject: [PATCH] x86: vdso: Use $LD instead of $CC to link
>
Have you tested 4.4.180? There were two subsequent fixes to this patch
in 4.4:
485d15db01ca ("kbuild: simplify ld-option implementation")
07d35512e494 ("x86/vdso: Pass --eh-frame-hdr to the linker")
> And, indeed, when I back this patch out of 4.4.178 proper, the above test
> passes again.
>
> Please consider backing this patch out of linux-4.4.y, and from master, and from
> any other linux branch it has been backported to.
>
So this is broken in mainline too?
> PS: In backing it out of 4.4.178, I first backed out
>
> 7c45b45fd6e928c9ce275c32f6fa98d317e6f5ee
>
> This is a follow-on vdso patch which collides with the
> patch we are interested in removing. As it claims to be
> only removing redundant code, it probably should never
> have been backported in the first place.
While it is redundant for ld.bfd, it causes a build failure with the
release version of ld.lld:
https://github.com/ClangBuiltLinux/linux/issues/31
Cheers,
Nathan
next prev parent reply other threads:[~2019-06-06 23:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 21:11 [BUG 4.4.178] x86_64 compat mode futexes broken Joe Korty
2019-06-06 23:11 ` Nathan Chancellor [this message]
2019-06-07 1:01 ` Joe Korty
2019-06-07 2:10 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606231130.GA69331@archlinux-epyc \
--to=natechancellor@gmail.com \
--cc=Joe.Korty@concurrent-rt.com \
--cc=astrachan@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).