From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3CA8C2BCA1 for ; Fri, 7 Jun 2019 15:51:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B248320840 for ; Fri, 7 Jun 2019 15:51:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559922671; bh=uCnlImr1sCXDHtdWF4PMIdW6NHznW4leojAu0sMNET4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=oUd3tBSqOFswHb63v4DqlZeXWn7iClubtyNCP717inI3/FnSEAcreYu8hclj7HV4W krun9oy+YIf3PpBzzmoXo2jpYQeKgL9Kw6HukBgQHrVIWfzug2ZNfSpTtdwKZBw6Q0 y1hvjtA9xPeQ7HgQGxW58aF7TJdHgzEvX9uKNFDA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732263AbfFGPvB (ORCPT ); Fri, 7 Jun 2019 11:51:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:38284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732259AbfFGPvA (ORCPT ); Fri, 7 Jun 2019 11:51:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6DA252146E; Fri, 7 Jun 2019 15:50:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559922659; bh=uCnlImr1sCXDHtdWF4PMIdW6NHznW4leojAu0sMNET4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lN1KI7cwD2QO/RNqtCF/s6UjKvS+C3Gkpmesc1fho92u9wVhOpGlJfmANiKStzAt0 /wVfCyxrU4dLhGZG2Bs8wDCHHPnNzonAvCu0ZO7daYJVEt6P/3dDA2r3pT2LoCvVAm IOZRkWPXFWBPNl41S4WCvD3+MpZHEcmucM5JM/qA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thomas Hellstrom , Deepak Rawat Subject: [PATCH 5.1 72/85] drm/vmwgfx: Fix user space handle equal to zero Date: Fri, 7 Jun 2019 17:39:57 +0200 Message-Id: <20190607153857.107552334@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190607153849.101321647@linuxfoundation.org> References: <20190607153849.101321647@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Thomas Hellstrom commit 8407f8a1d940fe28c4243ad4f0cb6a44dcee88f6 upstream. User-space handles equal to zero are interpreted as uninitialized or illegal by some drm systems (most notably kms). This means that a dumb buffer or surface with a zero user-space handle can never be used as a kms frame-buffer. Cc: Fixes: c7eae62666ad ("drm/vmwgfx: Make the object handles idr-generated") Signed-off-by: Thomas Hellstrom Reviewed-by: Deepak Rawat Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/vmwgfx/ttm_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/vmwgfx/ttm_object.c +++ b/drivers/gpu/drm/vmwgfx/ttm_object.c @@ -174,7 +174,7 @@ int ttm_base_object_init(struct ttm_obje kref_init(&base->refcount); idr_preload(GFP_KERNEL); spin_lock(&tdev->object_lock); - ret = idr_alloc(&tdev->idr, base, 0, 0, GFP_NOWAIT); + ret = idr_alloc(&tdev->idr, base, 1, 0, GFP_NOWAIT); spin_unlock(&tdev->object_lock); idr_preload_end(); if (ret < 0)