From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42DA7C28EBD for ; Sun, 9 Jun 2019 17:12:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1CBC3205F4 for ; Sun, 9 Jun 2019 17:12:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560100354; bh=uUxkPqFQilc1zz9Bg/0e7rKTxIztRsjn991NqXP2H+4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=i9IQ028vaSysfRuEwaICMRj0Org7z2LdLzP9xUe55cUX9z5a62DXYhMN1jfXEUdYr diwHujY0/5LgZpsTH0ByB2v4MkJ7PvcDX34QUeMaiW71BPGNoWmJbW4bxiXwIO6sD2 8oaOm7fN+pvKAMW93IbvGcmb6b/j18bmyn296INg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732780AbfFIQ7j (ORCPT ); Sun, 9 Jun 2019 12:59:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:35570 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733212AbfFIQ7i (ORCPT ); Sun, 9 Jun 2019 12:59:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D4808207E0; Sun, 9 Jun 2019 16:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560099577; bh=uUxkPqFQilc1zz9Bg/0e7rKTxIztRsjn991NqXP2H+4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QMedhCNnKSB/qYuZpNtUmb0ZFUX/CFAGA1e3l23b0hmr/aWrX3VxOljJy2AY/o72L w1eig5zU0phdaFUVDRQGSqdSk5ltyzIhjrqN4qCrCatl2XF2h/dqW0H5is5uKkd8vs kXkK3sbOO+9TCWUj2dEQy6a3WfXXYaUupZN+NN4g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexander Potapenko , Syzbot , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 4.4 088/241] media: vivid: use vfree() instead of kfree() for dev->bitmap_cap Date: Sun, 9 Jun 2019 18:40:30 +0200 Message-Id: <20190609164150.313262931@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190609164147.729157653@linuxfoundation.org> References: <20190609164147.729157653@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Alexander Potapenko commit dad7e270ba712ba1c99cd2d91018af6044447a06 upstream. syzkaller reported crashes on kfree() called from vivid_vid_cap_s_selection(). This looks like a simple typo, as dev->bitmap_cap is allocated with vzalloc() throughout the file. Fixes: ef834f7836ec0 ("[media] vivid: add the video capture and output parts") Signed-off-by: Alexander Potapenko Reported-by: Syzbot Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/vivid/vivid-vid-cap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/platform/vivid/vivid-vid-cap.c +++ b/drivers/media/platform/vivid/vivid-vid-cap.c @@ -993,7 +993,7 @@ int vivid_vid_cap_s_selection(struct fil rect_map_inside(&s->r, &dev->fmt_cap_rect); if (dev->bitmap_cap && (compose->width != s->r.width || compose->height != s->r.height)) { - kfree(dev->bitmap_cap); + vfree(dev->bitmap_cap); dev->bitmap_cap = NULL; } *compose = s->r;