From: Vinod Koul <vkoul@kernel.org>
To: yibin.gong@nxp.com
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
dan.j.williams@intel.com, thesven73@gmail.com,
m.olbrich@pengutronix.de, linux-imx@nxp.com,
stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
dmaengine@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2] dmaengine: imx-sdma: remove BD_INTR for channel0
Date: Fri, 5 Jul 2019 13:16:26 +0530 [thread overview]
Message-ID: <20190705074626.GB2911@vkoul-mobl> (raw)
In-Reply-To: <20190621082306.34415-1-yibin.gong@nxp.com>
On 21-06-19, 16:23, yibin.gong@nxp.com wrote:
> From: Robin Gong <yibin.gong@nxp.com>
>
> It is possible for an irq triggered by channel0 to be received later
> after clks are disabled once firmware loaded during sdma probe. If
> that happens then clearing them by writing to SDMA_H_INTR won't work
> and the kernel will hang processing infinite interrupts. Actually,
> don't need interrupt triggered on channel0 since it's pollling
> SDMA_H_STATSTOP to know channel0 done rather than interrupt in
> current code, just clear BD_INTR to disable channel0 interrupt to
> avoid the above case.
> This issue was brought by commit 1d069bfa3c78 ("dmaengine: imx-sdma:
> ack channel 0 IRQ in the interrupt handler") which didn't take care
> the above case.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2019-07-05 7:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 8:23 [PATCH v2] dmaengine: imx-sdma: remove BD_INTR for channel0 yibin.gong
2019-06-21 12:53 ` Michael Olbrich
2019-06-21 13:12 ` Sven Van Asbroeck
2019-06-24 12:54 ` Fabio Estevam
2019-06-25 7:36 ` Robin Gong
2019-06-25 15:45 ` Fabio Estevam
2019-07-05 7:46 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705074626.GB2911@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=m.olbrich@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=thesven73@gmail.com \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).