From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Douglas Anderson <dianders@chromium.org>,
stable@vger.kernel.org, groeck@chromium.org,
gregkh@linuxfoundation.org, sukhomlinov@google.com,
Arnd Bergmann <arnd@arndb.de>, Peter Huewe <peterhuewe@gmx.de>,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org
Subject: Re: [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations
Date: Fri, 12 Jul 2019 08:58:10 -0300 [thread overview]
Message-ID: <20190712115810.GA27512@ziepe.ca> (raw)
In-Reply-To: <20190712033556.4pze65z7cxga5tdu@linux.intel.com>
On Fri, Jul 12, 2019 at 06:35:56AM +0300, Jarkko Sakkinen wrote:
> On Fri, Jul 12, 2019 at 06:31:38AM +0300, Jarkko Sakkinen wrote:
> > On Thu, Jul 11, 2019 at 04:46:26PM -0300, Jason Gunthorpe wrote:
> > > On Thu, Jul 11, 2019 at 10:43:13PM +0300, Jarkko Sakkinen wrote:
> > > > On Thu, Jul 11, 2019 at 09:35:33PM +0300, Jarkko Sakkinen wrote:
> > > > > > Careful with this, you can't backport this to any kernels that don't
> > > > > > have the sysfs ops locking changes or they will crash in sysfs code.
> > > > >
> > > > > Oops, I was way too fast! Thanks Jason.
> > > >
> > > > Hmm... hold on a second.
> > > >
> > > > How would the crash realize? I mean this is at the point when user space
> > > > should not be active.
> > >
> > > Not strictly, AFAIK
> > >
> > > > Secondly, why the crash would not realize with
> > > > TPM2? The only thing the fix is doing is to do the same thing with TPM1
> > > > essentially.
> > >
> > > TPM2 doesn't use the unlocked sysfs path
> >
> > Gah, sorry :-) I should have known that.
> >
> > I can go through the patches needed when I come back from my leave after
> > two weeks.
>
> It might require a number of patches but maybe it makes also overally sense
> to fix the racy sysfs code in stable kernels.
The sysfs isn't racy, it justs used a different locking scheme
Jason
next prev parent reply other threads:[~2019-07-12 11:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 16:29 [PATCH] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations Douglas Anderson
2019-07-11 16:39 ` Jason Gunthorpe
2019-07-11 16:41 ` Doug Anderson
2019-07-11 17:04 ` Greg KH
2019-07-11 17:17 ` Jason Gunthorpe
2019-07-11 17:26 ` Greg KH
2019-07-11 17:28 ` Doug Anderson
2019-07-12 11:50 ` Greg KH
2019-07-12 15:00 ` Doug Anderson
2019-07-12 15:27 ` Greg KH
2019-08-05 21:05 ` Jarkko Sakkinen
2019-07-12 15:47 ` Jarkko Sakkinen
2019-07-12 15:21 ` Jarkko Sakkinen
2019-07-11 18:35 ` Jarkko Sakkinen
2019-07-11 19:43 ` Jarkko Sakkinen
2019-07-11 19:46 ` Jason Gunthorpe
2019-07-12 3:31 ` Jarkko Sakkinen
2019-07-12 3:35 ` Jarkko Sakkinen
2019-07-12 11:58 ` Jason Gunthorpe [this message]
2019-07-11 19:55 ` Doug Anderson
2019-07-11 18:34 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712115810.GA27512@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=arnd@arndb.de \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
--cc=sukhomlinov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).