From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C633C742BC for ; Fri, 12 Jul 2019 12:41:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15ED42166E for ; Fri, 12 Jul 2019 12:41:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562935276; bh=UoV8L7qo+XMutDisrOqQ2Nl63vl8UkSaqOPSlJTubfM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qrqynUWeLGyjxTg4hFLwoPUo09MsnRf14NvkbB4rS+LeaZGOQKqBaLRDCtx6Bov61 LFUtrmOI0LT5Y8s3Q3T9gZRmuJ/8NsyXbE0pMhiMNYrB2+jkMt4CcPAWvup7OcQ9rc F7xND/2KHw5EFHSWQ1MGk0Tti1aKwrM7mC3WJFuo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728081AbfGLMYT (ORCPT ); Fri, 12 Jul 2019 08:24:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:60976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728078AbfGLMYT (ORCPT ); Fri, 12 Jul 2019 08:24:19 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C4332084B; Fri, 12 Jul 2019 12:24:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562934258; bh=UoV8L7qo+XMutDisrOqQ2Nl63vl8UkSaqOPSlJTubfM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zVruzWb3RxfxK1fajB/1wrxsVX1hsskuWpd0yNWrUs0egQjavgth6UD84vgygjHog Dw+sEXEBqSk0HDQXwrcw9yRAoNTNEgbIt/4bHTdFKEPrWDRSwXwldXVbHBJTyr3tDp JnFggrObp7SFCgO+8uBXC8Io5DxaPCk8NRN99usA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King Subject: [PATCH 4.19 86/91] staging: fsl-dpaa2/ethsw: fix memory leak of switchdev_work Date: Fri, 12 Jul 2019 14:19:29 +0200 Message-Id: <20190712121626.341957714@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190712121621.422224300@linuxfoundation.org> References: <20190712121621.422224300@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Colin Ian King commit 5555ebbbac822b4fa28db2be15aaf98b3c21af26 upstream. In the default event case switchdev_work is being leaked because nothing is queued for work. Fix this by kfree'ing switchdev_work before returning NOTIFY_DONE. Addresses-Coverity: ("Resource leak") Fixes: 44baaa43d7cc ("staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver") Signed-off-by: Colin Ian King Signed-off-by: Greg Kroah-Hartman --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c @@ -1073,6 +1073,7 @@ static int port_switchdev_event(struct n dev_hold(dev); break; default: + kfree(switchdev_work); return NOTIFY_DONE; }