Stable Archive on
 help / color / Atom feed
From: Nathan Chancellor <>
To: kbuild test robot <>,
	Greg Kroah-Hartman <>,
	Sasha Levin <>
Cc:, Nick Desaulniers <>,
Subject: Re: [linux-stable-rc:linux-4.14.y 9981/9999] arch/x86/kernel/ptrace.c:659:22: warning: ISO C90 forbids mixing declarations and code
Date: Sat, 13 Jul 2019 20:41:25 -0700
Message-ID: <20190714034125.GA90669@archlinux-threadripper> (raw)
In-Reply-To: <>

On Sun, Jul 14, 2019 at 06:55:15AM +0800, kbuild test robot wrote:
> CC:
> TO: Dianzhang Chen <>
> CC: "Greg Kroah-Hartman" <>
> CC: Thomas Gleixner <>
> tree: linux-4.14.y
> head:   728f3eef5bdde0f9516277b4c4519fa5436e7e5d
> commit: 55ac552ebd34f9687cc1bdcb07006bf7f104dc99 [9981/9999] x86/ptrace: Fix possible spectre-v1 in ptrace_get_debugreg()
> config: x86_64-rhel-7.2 (attached as .config)
> compiler: clang version 9.0.0 (git://gitmirror/llvm_project 87856e739c8e55f3b4e0f37baaf93308ec2dbd47)
> reproduce:
>         git checkout 55ac552ebd34f9687cc1bdcb07006bf7f104dc99
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <>
> All warnings (new ones prefixed by >>):
> >> arch/x86/kernel/ptrace.c:659:22: warning: ISO C90 forbids mixing declarations and code [-Wdeclaration-after-statement]
>                    struct perf_event *bp = thread->ptrace_bps[index];
>                                       ^
>    1 warning generated.
> vim +659 arch/x86/kernel/ptrace.c
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
>                   Intel Corporation

Hi Greg and Sasha,

I was going to reply to this on the GCC version of the thread but I
don't really see a way to get the original message or the message ID
from the web archive since I'm not subscribed to that list :(

This is not an issue in Linus' tree because he fixed it manually during
the merge:

I would say that it isn't unreasonable to fold that fixup into the
original patch, with a note that it came from Linus' merge upstream:

223cea6a4f05 ("Merge branch 'x86-pti-for-linus' of


       reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2019-07-14  3:41 ` Nathan Chancellor [this message]
2019-07-14  3:45   ` Nathan Chancellor
2019-07-14  5:54     ` Greg Kroah-Hartman

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190714034125.GA90669@archlinux-threadripper \ \
    --cc=clang-built-linux@googlegroups \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Stable Archive on

Archives are clonable:
	git clone --mirror stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ \
	public-inbox-index stable

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox