Stable Archive on lore.kernel.org
 help / color / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: kbuild test robot <lkp@intel.com>,
	Sasha Levin <sashal@kernel.org>,
	kbuild@01.org, Nick Desaulniers <ndesaulniers@google.com>,
	clang-built-linux@googlegroups.com, stable@vger.kernel.org
Subject: Re: [linux-stable-rc:linux-4.14.y 9981/9999] arch/x86/kernel/ptrace.c:659:22: warning: ISO C90 forbids mixing declarations and code
Date: Sun, 14 Jul 2019 07:54:33 +0200
Message-ID: <20190714055433.GA8005@kroah.com> (raw)
In-Reply-To: <20190714034554.GD90669@archlinux-threadripper>

On Sat, Jul 13, 2019 at 08:45:54PM -0700, Nathan Chancellor wrote:
> On Sat, Jul 13, 2019 at 08:41:25PM -0700, Nathan Chancellor wrote:
> > On Sun, Jul 14, 2019 at 06:55:15AM +0800, kbuild test robot wrote:
> > > CC: kbuild-all@01.org
> > > TO: Dianzhang Chen <dianzhangchen0@gmail.com>
> > > CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
> > > CC: Thomas Gleixner <tglx@linutronix.de>
> > > 
> > > tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> > > head:   728f3eef5bdde0f9516277b4c4519fa5436e7e5d
> > > commit: 55ac552ebd34f9687cc1bdcb07006bf7f104dc99 [9981/9999] x86/ptrace: Fix possible spectre-v1 in ptrace_get_debugreg()
> > > config: x86_64-rhel-7.2 (attached as .config)
> > > compiler: clang version 9.0.0 (git://gitmirror/llvm_project 87856e739c8e55f3b4e0f37baaf93308ec2dbd47)
> > > reproduce:
> > >         git checkout 55ac552ebd34f9687cc1bdcb07006bf7f104dc99
> > >         # save the attached .config to linux build tree
> > >         make ARCH=x86_64 
> > > 
> > > If you fix the issue, kindly add following tag
> > > Reported-by: kbuild test robot <lkp@intel.com>
> > > 
> > > All warnings (new ones prefixed by >>):
> > > 
> > > >> arch/x86/kernel/ptrace.c:659:22: warning: ISO C90 forbids mixing declarations and code [-Wdeclaration-after-statement]
> > >                    struct perf_event *bp = thread->ptrace_bps[index];
> > >                                       ^
> > >    1 warning generated.
> > > 
> > > vim +659 arch/x86/kernel/ptrace.c
> > > 
> > > ---
> > > 0-DAY kernel test infrastructure                Open Source Technology Center
> > > https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> > 
> > Hi Greg and Sasha,
> > 
> > I was going to reply to this on the GCC version of the thread but I
> > don't really see a way to get the original message or the message ID
> > from the web archive since I'm not subscribed to that list :(
> > 
> > https://lists.01.org/pipermail/kbuild-all/2019-July/062379.html
> > 
> > This is not an issue in Linus' tree because he fixed it manually during
> > the merge:
> > 
> > https://lore.kernel.org/lkml/CAHk-=whhq5RQYNKzHOLqC+gzSjmcEGNJjbC=Psc_vQaCx4TCKg@mail.gmail.com/
> > 
> > I would say that it isn't unreasonable to fold that fixup into the
> > original patch, with a note that it came from Linus' merge upstream:
> > 
> > 223cea6a4f05 ("Merge branch 'x86-pti-for-linus' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip").
> > 
> > Cheers,
> > Nathan
> 
> Re-adding our list, which I messed up when adding stable. Sorry for the
> noise :(

Ah, didn't realize it was fixed during the merge, will do the same thing
here and tweak the original patch.

thanks,

greg k-h

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201907140611.AydIXYEe%lkp@intel.com>
2019-07-14  3:41 ` Nathan Chancellor
2019-07-14  3:45   ` Nathan Chancellor
2019-07-14  5:54     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190714055433.GA8005@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=kbuild@01.org \
    --cc=lkp@intel.com \
    --cc=natechancellor@gmail.com \
    --cc=ndesaulniers@google.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Stable Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://lore.kernel.org/stable \
		stable@vger.kernel.org stable@archiver.kernel.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox