Stable Archive on
 help / color / Atom feed
* [patch 06/18] mm/z3fold.c: fix z3fold_destroy_pool() ordering
@ 2019-08-13 22:37 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2019-08-13 22:37 UTC (permalink / raw)
  To: vitalywool, vitaly.vul, viro, tglx, stable, shakeelb, jwadams,
	henrywolfeburns, dhowells, henryburns, akpm, mm-commits,

From: Henry Burns <>
Subject: mm/z3fold.c: fix z3fold_destroy_pool() ordering

The constraint from the zpool use of z3fold_destroy_pool() is there are
no outstanding handles to memory (so no active allocations), but it is
possible for there to be outstanding work on either of the two wqs in
the pool.

If there is work queued on pool->compact_workqueue when it is called,
z3fold_destroy_pool() will do:

             __release_z3fold_page(zhdr, ...)
               queue_work_on(pool->release_wq, &pool->work) *BOOM*

So compact_wq needs to be destroyed before release_wq.

Fixes: 5d03a6613957 ("mm/z3fold.c: use kref to prevent page free/compact race")
Signed-off-by: Henry Burns <>
Reviewed-by: Shakeel Butt <>
Reviewed-by: Jonathan Adams <>
Cc: Vitaly Vul <>
Cc: Vitaly Wool <>
Cc: David Howells <>
Cc: Thomas Gleixner <>
Cc: Al Viro <
Cc: Henry Burns <>
Cc: <>
Signed-off-by: Andrew Morton <>

 mm/z3fold.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

--- a/mm/z3fold.c~mm-z3foldc-fix-z3fold_destroy_pool-ordering
+++ a/mm/z3fold.c
@@ -818,8 +818,15 @@ static void z3fold_destroy_pool(struct z
-	destroy_workqueue(pool->release_wq);
+	/*
+	 * We need to destroy pool->compact_wq before pool->release_wq,
+	 * as any pending work on pool->compact_wq will call
+	 * queue_work(pool->release_wq, &pool->work).
+	 */
+	destroy_workqueue(pool->release_wq);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 22:37 [patch 06/18] mm/z3fold.c: fix z3fold_destroy_pool() ordering akpm

Stable Archive on

Archives are clonable:
	git clone --mirror stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ \
	public-inbox-index stable

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox