From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80050C32753 for ; Wed, 14 Aug 2019 17:17:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 531422084D for ; Wed, 14 Aug 2019 17:17:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565803056; bh=wvmpk6+fz8d+5hIrcn2Y0L+EjVGwztU49Pg1//2cPKM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1u/O1xR5/NObNdqOV1qtJCvK3b4nfvzqaIh9/iq+B8l7QzemWfZQAamEY/RKmr2gt 0ofdX2Z247QpDfq3LN0Lq4PektxXLxCCWBvXudrJxB0RNnZSj9UQb5C6YxA0ltU50O JMfF43oe4wcjy7+u4JjCCfWMRkHCFPf/MZSi2nYw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730854AbfHNRNO (ORCPT ); Wed, 14 Aug 2019 13:13:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:37404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730828AbfHNRNM (ORCPT ); Wed, 14 Aug 2019 13:13:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F03632084D; Wed, 14 Aug 2019 17:13:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802792; bh=wvmpk6+fz8d+5hIrcn2Y0L+EjVGwztU49Pg1//2cPKM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qVXEol2dHgf+aTleqxLy9WE+Qe4WG7D86ClndSBvbmIIFs1HZ8OI4Nhcjv4nBpCuE cz9nier2yYZmlIf0Uob7PBt94IJ9tmy6dr+Deys47jk6+sLWf/D4oB6bd+wQ5zo2TI x2KFmOFHFWNO9dSut+DOFLvLX5BTtVTvr5HAgCW4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Laura Garcia Liebana , Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 4.14 28/69] netfilter: nft_hash: fix symhash with modulus one Date: Wed, 14 Aug 2019 19:01:26 +0200 Message-Id: <20190814165747.428288200@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190814165744.822314328@linuxfoundation.org> References: <20190814165744.822314328@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 28b1d6ef53e3303b90ca8924bb78f31fa527cafb ] The rule below doesn't work as the kernel raises -ERANGE. nft add rule netdev nftlb lb01 ip daddr set \ symhash mod 1 map { 0 : 192.168.0.10 } fwd to "eth0" This patch allows to use the symhash modulus with one element, in the same way that the other types of hashes and algorithms that uses the modulus parameter. Signed-off-by: Laura Garcia Liebana Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/nft_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nft_hash.c b/net/netfilter/nft_hash.c index 24f2f7567ddb7..010a565b40001 100644 --- a/net/netfilter/nft_hash.c +++ b/net/netfilter/nft_hash.c @@ -131,7 +131,7 @@ static int nft_symhash_init(const struct nft_ctx *ctx, priv->dreg = nft_parse_register(tb[NFTA_HASH_DREG]); priv->modulus = ntohl(nla_get_be32(tb[NFTA_HASH_MODULUS])); - if (priv->modulus <= 1) + if (priv->modulus < 1) return -ERANGE; if (priv->offset + priv->modulus - 1 < priv->offset) -- 2.20.1