From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCCA6C433FF for ; Wed, 14 Aug 2019 17:02:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91EBA21721 for ; Wed, 14 Aug 2019 17:02:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802158; bh=Tt2EqeaocrgyBp4xquR/jMgpydrdFvFboGMgsd9PDgM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=x/MQR4hyADJHUhKkMCmyRuURuLMUKzkZ+Sb1hEeY54M8F0yLFTlBPEbE6snoDP+Mo VbK8wnDB2fFcerKQAboToeIymiwS8jEEWsyd3eaIymOidqgUThPerSfVFa143ALnJO aza1ZnELM2PyR7bQ7GuJ4aCxs3l9RYLEktl/KGpQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728654AbfHNRCh (ORCPT ); Wed, 14 Aug 2019 13:02:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:51078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728674AbfHNRCg (ORCPT ); Wed, 14 Aug 2019 13:02:36 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2EE97214DA; Wed, 14 Aug 2019 17:02:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565802155; bh=Tt2EqeaocrgyBp4xquR/jMgpydrdFvFboGMgsd9PDgM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=w0Lt7H/1vL9vPipNyWw933GAqnsgb2PZxN8vBN5nf36SB0KJ+TjajArKO4GBSlk9t +0evR3Np0HIv2+h2elxjrYmeuPaArtnG8DydSHY2DbFyM2p2XOZZsxgF1hjKU6XnFB 4wPojqtq1URapxWCFENCPprQ6gjhzsrNZT4JTp5Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Gavin Li , Alan Stern Subject: [PATCH 5.2 016/144] usb: usbfs: fix double-free of usb memory upon submiturb error Date: Wed, 14 Aug 2019 18:59:32 +0200 Message-Id: <20190814165800.583805711@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190814165759.466811854@linuxfoundation.org> References: <20190814165759.466811854@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Gavin Li commit c43f28dfdc4654e738aa6d3fd08a105b2bee758d upstream. Upon an error within proc_do_submiturb(), dec_usb_memory_use_count() gets called once by the error handling tail and again by free_async(). Remove the first call. Signed-off-by: Gavin Li Acked-by: Alan Stern Cc: stable Link: https://lore.kernel.org/r/20190804235044.22327-1-gavinli@thegavinli.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/core/devio.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -1788,8 +1788,6 @@ static int proc_do_submiturb(struct usb_ return 0; error: - if (as && as->usbm) - dec_usb_memory_use_count(as->usbm, &as->usbm->urb_use_count); kfree(isopkt); kfree(dr); if (as)