From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A79A1C3A5A2 for ; Tue, 3 Sep 2019 15:41:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 756822077B for ; Tue, 3 Sep 2019 15:41:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="iMLtZahe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728967AbfICPlQ (ORCPT ); Tue, 3 Sep 2019 11:41:16 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:53684 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728860AbfICPlP (ORCPT ); Tue, 3 Sep 2019 11:41:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ULjjH4sen9zfb9BXYRsup9ADAXBJxX8uc7RUDCdLvBI=; b=iMLtZaheRsuIIVHr5rl4845Z/ DQ4Krr08gV8xH84IYbia5dX0+JhszL5ZcZBnSeyExOmZFBqXF7CcL2MNVCZCq9tyJtdZYKwrJmZCb EglUAwGDTmn5HoxA89fVRVoWsmuRCXZTwoEp2Q03cznjk1R5NHDz0Fo2WlVGzKhnuBdGIUo1hb3Y9 uT4AtWQHg+LuKzFCXP79w6r3cLv6R7QKv1ZIzJHSzD3byMeBY9RB+Nqg9cSLyx5BUR2r8yRKVB/ny +O2cQUg5jS8QXvSKwizythOZTh3Qt2gWBn9gS3WJ0y5IR1cPNFSd53JleIPN/dwvgrOd3Pv3qQt+F WrdrrEDEw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i5Avd-0002Gk-UO; Tue, 03 Sep 2019 15:41:09 +0000 Date: Tue, 3 Sep 2019 08:41:09 -0700 From: Christoph Hellwig To: Mike Travis Cc: Christoph Hellwig , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andrew Morton , Borislav Petkov , Dimitri Sivanich , Russ Anderson , Hedi Berriche , Steve Wahl , x86@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 2/8] x86/platform/uv: Return UV Hubless System Type Message-ID: <20190903154109.GB2791@infradead.org> References: <20190903001815.504418099@stormcage.eag.rdlabs.hpecorp.net> <20190903001815.893030884@stormcage.eag.rdlabs.hpecorp.net> <20190903064914.GA9914@infradead.org> <0eee6d96-e4fc-763b-a8b9-52c85ddd5531@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0eee6d96-e4fc-763b-a8b9-52c85ddd5531@hpe.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Sep 03, 2019 at 07:12:28AM -0700, Mike Travis wrote: > > > +#define is_uv_hubless _is_uv_hubless > > > > Why the weird macro indirection? > > > > > -static inline int is_uv_hubless(void) { return 0; } > > > +static inline int _is_uv_hubless(int uv) { return 0; } > > > +#define is_uv_hubless _is_uv_hubless > > > > And here again. > > > > Sorry, I should have explained this better. The problem arises because > we have a number of UV specific kernel modules that support multiple > distributions. And with back porting to earlier distros we cannot > rely on the KERNEL_VERSION macro to define whether the source is being > built for an earlier kernel. So this allows an ifdef on the function > name to discover if the kernel is before or after these changes. And none of these matter for upstream. We'd rather not make the code more convouluted than required. If you actually really cared about these modules you would simply submit them upstream.