From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F332DC3A5A2 for ; Tue, 3 Sep 2019 16:32:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2C9E23431 for ; Tue, 3 Sep 2019 16:32:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567528350; bh=4UCNBBxw3LhMunVdWAChjEp/I1fLorG7hxA5sRYINWg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OGUKWWshhLSt8WbcCkpq7dbt/txAeaiDchXI3hNaJPjqlcFHGl5xJOEguQy98c6tw AOJmS9DWu+lCxME0GpJCkTsljqu1Gl9jz0X5ke5Wa1VdBh5aN6s/7IB0htgWYBteri 9QYwH9eAqxREc5dRZbxmHQgkwFZ+/TYvJnJNXYEM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730983AbfICQcZ (ORCPT ); Tue, 3 Sep 2019 12:32:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:55858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731431AbfICQcR (ORCPT ); Tue, 3 Sep 2019 12:32:17 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0C964215EA; Tue, 3 Sep 2019 16:32:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567528336; bh=4UCNBBxw3LhMunVdWAChjEp/I1fLorG7hxA5sRYINWg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AvX/AsKiN5L3MmSggGQmEx+Ngq7mvRY3gs7uvjeaGXZW96tnA/OeVJJ4QvI/HBaQ8 knkWtxmkavC/C3oIqiNmmbqooMdZB7ivpfcqtelgxNrtsRa7AKGuuH5cBG/2RqgKDW 3hzYsZSrHka23wr7nuecu7S79KhtXggdO8VguI68= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Colin Ian King , Theodore Ts'o , Sasha Levin , linux-ext4@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 166/167] ext4: unsigned int compared against zero Date: Tue, 3 Sep 2019 12:25:18 -0400 Message-Id: <20190903162519.7136-166-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190903162519.7136-1-sashal@kernel.org> References: <20190903162519.7136-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Colin Ian King [ Upstream commit fbbbbd2f28aec991f3fbc248df211550fbdfd58c ] There are two cases where u32 variables n and err are being checked for less than zero error values, the checks is always false because the variables are not signed. Fix this by making the variables ints. Addresses-Coverity: ("Unsigned compared against 0") Fixes: 345c0dbf3a30 ("ext4: protect journal inode's blocks using block_validity") Signed-off-by: Colin Ian King Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/ext4/block_validity.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c index cd7129b622f85..e8e27cdc2f677 100644 --- a/fs/ext4/block_validity.c +++ b/fs/ext4/block_validity.c @@ -142,7 +142,8 @@ static int ext4_protect_reserved_inode(struct super_block *sb, u32 ino) struct inode *inode; struct ext4_sb_info *sbi = EXT4_SB(sb); struct ext4_map_blocks map; - u32 i = 0, err = 0, num, n; + u32 i = 0, num; + int err = 0, n; if ((ino < EXT4_ROOT_INO) || (ino > le32_to_cpu(sbi->s_es->s_inodes_count))) -- 2.20.1