From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAEFAC43331 for ; Fri, 6 Sep 2019 18:29:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82071214DE for ; Fri, 6 Sep 2019 18:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567794561; bh=le0ALQaDnlgcqarLRMQtu/QI4EFwGOH5PX4ms/GeKIc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=csaKg+J1YE1+9LdNJyv2k54xjJl9yQZdc4Du0cUDem6EzvZF9wHMz//7TTWBloO4/ FsYM1OcgXFikufisF75CE76gYw5JpJ1OHKLIxtNA3vhkIGP5vZQF6uzNgsaU3VbeZd hhB35djG3WS1BU8F/TuBZAFetdihlhYlrg7FGJT4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391944AbfIFS3V (ORCPT ); Fri, 6 Sep 2019 14:29:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:53954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391371AbfIFS3V (ORCPT ); Fri, 6 Sep 2019 14:29:21 -0400 Received: from localhost (unknown [62.28.240.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E1932082C; Fri, 6 Sep 2019 18:29:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567794560; bh=le0ALQaDnlgcqarLRMQtu/QI4EFwGOH5PX4ms/GeKIc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X1CemnEOLlGMFFQA8Axyn/In8fCt0xMKu+fHtjxyvyRkv17mkIZ32vkPn6sc0p9sl y+W1f89QWROdrPTlEACr0WRKklhLUYVQdmmxZ2E1Xzja+B7SBIEEy/hNZD8WWk9TpG qcJL9GwDQb2T9LCQXUJk57JUC5gHQa48AcfIXOoc= Date: Fri, 6 Sep 2019 14:29:17 -0400 From: Sasha Levin To: Ricard Wanderlof Cc: Greg Kroah-Hartman , Mark Brown , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: revert: ASoC: Fail card instantiation if DAI format setup fails Message-ID: <20190906182917.GA1528@sasha-vm> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Archived-At: List-Archive: List-Post: On Fri, Sep 06, 2019 at 05:00:28PM +0200, Ricard Wanderlof wrote: > >Sorry for the repost, I relized I stupidly got Greg's email adress wrong >first time around. > >> > On Tue, Aug 27, 2019 at 12:00:14PM +0100, Mark Brown wrote: >> > > On Sun, Aug 25, 2019 at 09:35:15PM -0400, Sasha Levin wrote: >> > > > On Wed, Aug 14, 2019 at 10:22:13AM +0100, Mark Brown wrote: >> > > >> > > > > > If the DAI format setup fails, there is no valid communication format >> > > > > > between CPU and CODEC, so fail card instantiation, rather than >> > > > continue >> > > > > > with a card that will most likely not function properly. >> > > >> > > > > This is another one where if nobody noticed a problem already and things >> > > > > just happened to be working this might break things, it's vanishingly >> > > > > unlikely to fix anything that was broken. >> > > >> > > > Same as the other patch: this patch suggests it fixes a real bug, and if >> > > > this patch is broken let's fix it. >> > > >> > > If anyone ran into this on the older kernel and fixed or worked >> > > around it locally there's a reasonable chance this will then >> > > break what they're doing. The patch itself is perfectly fine but > >(Sorry about the mangled subject line, I'd accidentally deleted the >original message from my inbox.) > >I'm a bit bewildered here. As the author of the original patch I'm of >course biased, and I can certainly understand the patch being dropped from >existing release branches, since as Mark correctly states, it does not fix >any broken behavior and might even break things that happen to work by >chance. > >But is this being dropped from the master branch as well? To me it makes >the kernel behave in an inconsistent way, first reporting a failure to >instantiate a specific sound card in the kernel log, but then seemingly >bringing it up anyway. Hi Richard, This patch is only dropped from the stable branches, it still remains in the mainline branch. -- Thanks, Sasha