From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F962C4332F for ; Sun, 8 Sep 2019 12:49:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EDCC82196F for ; Sun, 8 Sep 2019 12:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567946952; bh=IqEauNs7qeUy74R3qRiokvDUb9O7TGDvPagbktP5iyk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zlY0Cf7F1Lm7EjRl6DQCqhgsuL7i3533vSVN+PqWuCb0MeQKJikhqcrCr3Dz3wSPP NN+iqkxhPUqK0z/a3yZJ9dLn3FlBFtf1lDMqjb6xYbgeGsZ6bfO2Qmkzrm/oC58Uif lVdyv3q63dKaQQnRiMwz57Z5uuJgnC33xJU25ml0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731297AbfIHMtF (ORCPT ); Sun, 8 Sep 2019 08:49:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:38656 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731288AbfIHMtE (ORCPT ); Sun, 8 Sep 2019 08:49:04 -0400 Received: from localhost (unknown [62.28.240.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C6972190F; Sun, 8 Sep 2019 12:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567946943; bh=IqEauNs7qeUy74R3qRiokvDUb9O7TGDvPagbktP5iyk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GFfyVzz1kozti2CaYGKMk2eGz5KinkmezpuGtERySsg9xlasMi2oYewOBrPSmXiUB INCWLWLj5TmMb1gx0bu4tcS48QS8gGdjnY4iLnQmbMdlfhL7E8TwYHxkask8zuCSZC 08H4eexA+5817zI0xtRY5y+kCaHVIZleH7R9x6f0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenwen Wang , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 36/57] wimax/i2400m: fix a memory leak bug Date: Sun, 8 Sep 2019 13:42:00 +0100 Message-Id: <20190908121141.444791715@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190908121125.608195329@linuxfoundation.org> References: <20190908121125.608195329@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 44ef3a03252844a8753479b0cea7f29e4a804bdc ] In i2400m_barker_db_init(), 'options_orig' is allocated through kstrdup() to hold the original command line options. Then, the options are parsed. However, if an error occurs during the parsing process, 'options_orig' is not deallocated, leading to a memory leak bug. To fix this issue, free 'options_orig' before returning the error. Signed-off-by: Wenwen Wang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/wimax/i2400m/fw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wimax/i2400m/fw.c b/drivers/net/wimax/i2400m/fw.c index e9fc168bb7345..489cba9b284d1 100644 --- a/drivers/net/wimax/i2400m/fw.c +++ b/drivers/net/wimax/i2400m/fw.c @@ -351,13 +351,15 @@ int i2400m_barker_db_init(const char *_options) } result = i2400m_barker_db_add(barker); if (result < 0) - goto error_add; + goto error_parse_add; } kfree(options_orig); } return 0; +error_parse_add: error_parse: + kfree(options_orig); error_add: kfree(i2400m_barker_db); return result; -- 2.20.1