From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F043C49ED7 for ; Fri, 13 Sep 2019 14:55:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E84DC20830 for ; Fri, 13 Sep 2019 14:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568386501; bh=I7N/O9xEYf2S+/1euHytIwV3P/IP5katELShfV4ians=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Jbw4xd4nLBAfypPuo/KBPK1wj2gv49inXN7QHlRPIHiY19QAR9jeO5Yhi1ffE7v5C XtLuIhMNn0BjyTIXx+kjy/Nh9WTIhNgIDPTjNt9Kwtoch0OUMmhQcQjR5k4sjbRQZn nisU8xrp/qBmGLjU6tbNHBbTqadQXoc0JAgIj4q8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390055AbfIMOzA (ORCPT ); Fri, 13 Sep 2019 10:55:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:38318 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388225AbfIMOy7 (ORCPT ); Fri, 13 Sep 2019 10:54:59 -0400 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 74F4320830; Fri, 13 Sep 2019 14:54:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568386498; bh=I7N/O9xEYf2S+/1euHytIwV3P/IP5katELShfV4ians=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lqP1Wlpgl1cMbfKyUFPqE69Wyp3hjAEy9a+k4Npoq58NLF4T+5sA7hQgFJ663QAzU lyBgII60a9xGRS5jgWgDnhaOFwixdpzkmW2nWAeaczl2D/zBbbZXXm2UUP+nT1X2Cz tB4lAE0yZ+ub0QARhDWbUPMMk3U40fPlP5sVCK/M= Date: Fri, 13 Sep 2019 15:54:56 +0100 From: Greg Kroah-Hartman To: Sasha Levin Cc: Ilia Mirkin , LKML , dri-devel , Ben Skeggs , nouveau , "# 3.9+" Subject: Re: [PATCH 4.19 092/190] drm/nouveau: Dont WARN_ON VCPI allocation failures Message-ID: <20190913145456.GA456842@kroah.com> References: <20190913130559.669563815@linuxfoundation.org> <20190913130606.981926197@linuxfoundation.org> <20190913144627.GH1546@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190913144627.GH1546@sasha-vm> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Sep 13, 2019 at 10:46:27AM -0400, Sasha Levin wrote: > On Fri, Sep 13, 2019 at 09:33:36AM -0400, Ilia Mirkin wrote: > > Hi Greg, > > > > This feels like it's missing a From: line. > > > > commit b513a18cf1d705bd04efd91c417e79e4938be093 > > Author: Lyude Paul > > Date: Mon Jan 28 16:03:50 2019 -0500 > > > > drm/nouveau: Don't WARN_ON VCPI allocation failures > > > > Is this an artifact of your notification-of-patches process and I > > never noticed before, or was the patch ingested incorrectly? > > It was always like this for patches that came through me. Greg's script > generates an explicit "From:" line in the patch, but I never saw the > value in that since git does the right thing by looking at the "From:" > line in the mail header. > > The right thing is being done in stable-rc and for the releases. For > your example here, this is how it looks like in the stable-rc tree: > > commit bdcc885be68289a37d0d063cd94390da81fd8178 > Author: Lyude Paul > AuthorDate: Mon Jan 28 16:03:50 2019 -0500 > Commit: Greg Kroah-Hartman > CommitDate: Fri Sep 13 14:05:29 2019 +0100 > > drm/nouveau: Don't WARN_ON VCPI allocation failures Yeah, we should fix your scripts to put the explicit From: line in here as we are dealing with patches in this format and it causes confusion at times (like now.) It's not the first time and that's why I added those lines to the patches. thanks, greg k-h