From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93657C49ED7 for ; Fri, 13 Sep 2019 15:26:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6852D208C2 for ; Fri, 13 Sep 2019 15:26:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568388400; bh=DKPb89gNVWrEkc2nPeyAuBft6QGWxruAsXiGTHC2k3Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=XjvImv1gL/rYr33iAWPL1fwlC/Y6Z2DpIIB1jlcbEP/+hHHcdjsCbgi5BnmllRHKq 5rC8WQYUQ1Uocj1WSmo3mPc9ElwPvd309Yd0QT1/Md6Y7y7Dt5U6QRrgyXGcYDUil4 aRCiz096WqCnU2WrruyBnnYPncmSDfEK4ug/czP0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388884AbfIMP0j (ORCPT ); Fri, 13 Sep 2019 11:26:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:51174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388231AbfIMP0j (ORCPT ); Fri, 13 Sep 2019 11:26:39 -0400 Received: from localhost (195-23-252-136.net.novis.pt [195.23.252.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8CED520693; Fri, 13 Sep 2019 15:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568388398; bh=DKPb89gNVWrEkc2nPeyAuBft6QGWxruAsXiGTHC2k3Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PwShTKtviHhe7lIiolEaRlj1ESSWSdo+v7cy/OKAZtmXBjo527ajt4jQwK0y1ZJzW IBehPhMhu/14uOk9gIhFPv9u5APdEObhtfvM8txCfYfcvt5EeCWMQ4t1nk/enW5uVM h3e5fLu+ZkpXC5tKbSu3Nhs0CFtaeuqc+05KQMNY= Date: Fri, 13 Sep 2019 11:26:35 -0400 From: Sasha Levin To: Ilia Mirkin Cc: Greg Kroah-Hartman , LKML , dri-devel , Ben Skeggs , nouveau , "# 3.9+" Subject: Re: [PATCH 4.19 092/190] drm/nouveau: Dont WARN_ON VCPI allocation failures Message-ID: <20190913152635.GK1546@sasha-vm> References: <20190913130559.669563815@linuxfoundation.org> <20190913130606.981926197@linuxfoundation.org> <20190913144627.GH1546@sasha-vm> <20190913145456.GA456842@kroah.com> <20190913150111.GI1546@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Sep 13, 2019 at 11:09:22AM -0400, Ilia Mirkin wrote: >On Fri, Sep 13, 2019 at 11:01 AM Sasha Levin wrote: >> >> On Fri, Sep 13, 2019 at 03:54:56PM +0100, Greg Kroah-Hartman wrote: >> >On Fri, Sep 13, 2019 at 10:46:27AM -0400, Sasha Levin wrote: >> >> On Fri, Sep 13, 2019 at 09:33:36AM -0400, Ilia Mirkin wrote: >> >> > Hi Greg, >> >> > >> >> > This feels like it's missing a From: line. >> >> > >> >> > commit b513a18cf1d705bd04efd91c417e79e4938be093 >> >> > Author: Lyude Paul >> >> > Date: Mon Jan 28 16:03:50 2019 -0500 >> >> > >> >> > drm/nouveau: Don't WARN_ON VCPI allocation failures >> >> > >> >> > Is this an artifact of your notification-of-patches process and I >> >> > never noticed before, or was the patch ingested incorrectly? >> >> >> >> It was always like this for patches that came through me. Greg's script >> >> generates an explicit "From:" line in the patch, but I never saw the >> >> value in that since git does the right thing by looking at the "From:" >> >> line in the mail header. >> >> >> >> The right thing is being done in stable-rc and for the releases. For >> >> your example here, this is how it looks like in the stable-rc tree: >> >> >> >> commit bdcc885be68289a37d0d063cd94390da81fd8178 >> >> Author: Lyude Paul >> >> AuthorDate: Mon Jan 28 16:03:50 2019 -0500 >> >> Commit: Greg Kroah-Hartman >> >> CommitDate: Fri Sep 13 14:05:29 2019 +0100 >> >> >> >> drm/nouveau: Don't WARN_ON VCPI allocation failures >> > >> >Yeah, we should fix your scripts to put the explicit From: line in here >> >as we are dealing with patches in this format and it causes confusion at >> >times (like now.) It's not the first time and that's why I added those >> >lines to the patches. >> >> Heh, didn't think anyone cared about this scenario for the stable-rc >> patches. >> >> I'll go add it. >> >> But... why do you actually care? > >Just a hygiene thing. Everyone else sends patches the normal way, with >accurate attribution. Why should stable be different? It shouldn't. It's just a mismatch between our two somewhat seperate workflow. Technically it's Greg who needs to be adding that line since the patches I have in stable-queue correctly state the author, and it only goes wrong when they're being formatted into mails sent for the -rc cycles. But yes, thanks for pointing it out, I'll go add it in the scripts. -- Thanks, Sasha