From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D428ECE58C for ; Wed, 9 Oct 2019 20:51:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14AF82190F for ; Wed, 9 Oct 2019 20:51:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570654262; bh=h5UFSrQbxwQ1jaUrIAHWi1a2T2kESQj+kWn/elifWyI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=isyVbBtlty75GbAKeTcCD6Y7gmXw/wijvuMiMQoG1pq3PirsDbwa8U1YtKSzBEMic rYRFknNrpzkYpwODCNM5tkGaCDmCupMFzC1G7IQ4BI0W848Q7PJ+teIJPCUfkrddFM IhOjNMWM3IubvSf1gMM7xxUlqdcM+11FwLK299z4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731736AbfJIUvB (ORCPT ); Wed, 9 Oct 2019 16:51:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:37254 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729535AbfJIUvB (ORCPT ); Wed, 9 Oct 2019 16:51:01 -0400 Received: from localhost (unknown [167.220.2.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA02C218AC; Wed, 9 Oct 2019 20:51:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570654260; bh=h5UFSrQbxwQ1jaUrIAHWi1a2T2kESQj+kWn/elifWyI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XQuqQ6Z1qEUd6UB14Af4XMrwnjZf7DdyoQWxIwFF92Q2siHiJodulbfuvdzL3NDSQ I2hcwXyTNmAYvGuCeA7X+g5F4eJeT1igxgitz4B0HNL6pJNSYnVxut1HeDv+fSeTG1 +D4WRc3anrDkvyc7JJyZXfwSVzUXX8iN6Ewe/HhI= Date: Wed, 9 Oct 2019 16:51:00 -0400 From: Sasha Levin To: Linus Torvalds Cc: Linux Kernel Mailing List , stable , Alexander Viro , Jann Horn , "Eric W . Biederman" , linux-fsdevel Subject: Re: [PATCH AUTOSEL 4.19 26/26] Make filldir[64]() verify the directory entry filename is valid Message-ID: <20191009205100.GV1396@sasha-vm> References: <20191009170558.32517-1-sashal@kernel.org> <20191009170558.32517-26-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Oct 09, 2019 at 10:56:56AM -0700, Linus Torvalds wrote: >On Wed, Oct 9, 2019 at 10:24 AM Sasha Levin wrote: >> >> From: Linus Torvalds >> >> [ Upstream commit 8a23eb804ca4f2be909e372cf5a9e7b30ae476cd ] > >I didn't mark this for stable because I expect things to still change >- particularly the WARN_ON_ONCE() should be removed before final 5.4, >I just wanted to see if anybody could trigger it with testing etc. > >(At least syzbot did trigger it). > >If you do want to take it, take it without the WARN_ON_ONCE() calls >and note that in the commit message.. I'll take both when you send a patch to remove it. -- Thanks, Sasha