Stable Archive on lore.kernel.org
 help / color / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	will@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com
Subject: Re: [PATCH] arm64: cpufeature: Fix truncating a feature value
Date: Fri, 11 Oct 2019 14:13:00 +0200
Message-ID: <20191011121300.GA1144378@kroah.com> (raw)
In-Reply-To: <433563f1-1aad-f43b-a294-08cb39ba4818@arm.com>

On Fri, Oct 11, 2019 at 11:31:30AM +0100, Suzuki K Poulose wrote:
> Hi Greg,
> 
> On 11/10/2019 05:55, Greg KH wrote:
> > On Thu, Oct 10, 2019 at 02:19:43PM +0100, Suzuki K Poulose wrote:
> > > A signed feature value is truncated to turn to an unsigned value
> > > causing bad state in the system wide infrastructure. This affects
> > > the discovery of FP/ASIMD support on arm64. Fix this by making sure
> > > we cast it properly.
> > > 
> > > This was inadvertently fixed upstream in v4.6 onwards with the following :
> > > commit 28c5dcb22f90113dea ("arm64: Rename cpuid_feature field extract routines")
> > 
> > What prevents us from just taking that commit instead?  You did not
> > document that here at all, which I thought I asked for.
> 
> Sorry, I missed that part. So, that change introduces helpers to
> extract feature fields based on the sign. And it also depends on
> 
> commit ff96f7bc7bf6 ("arm64: capabilities: Handle sign of the feature bit")
> 
> which introduces "sign" bit for the "capability" list and modifies
> the generic capability->matches() helpers to use the hint to switch to the
> appropriate helpers.

That's ok, does that cause any problems?  We always want the original
patch instead of a one-off patch as that way we do not diverge.

> I could backport parts of the commit 28c5dcb22f90 dropping the bits
> that affect the changes mentioned above.

Please do, that is always prefered as well, but do the first thing above
if at all possible.

> > 
> > Also, you only need 12 digits for a sha1, 28c5dcb22f90 ("arm64: Rename
> > cpuid_feature field extract routines") would be just fine :)
> 
> Yea, I understand. Its simply a pain to count the numbers, so I make sure
> to pickup something that looks larger than the 12 ;-). I will try to stick
> to that :-)

	git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"
will give you the correct format.  I suggest making it a git alias :)

Or, use:
	[core]
	        abbrev = 12
in your .gitconfig file.

thanks,

greg k-h

      reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10 11:08 Suzuki K Poulose
2019-10-10 11:12 ` Suzuki K Poulose
2019-10-10 12:29   ` Greg KH
2019-10-10 12:46     ` Suzuki K Poulose
2019-10-10 13:16       ` Greg KH
2019-10-10 13:19     ` Suzuki K Poulose
2019-10-11  4:55       ` Greg KH
2019-10-11 10:31         ` Suzuki K Poulose
2019-10-11 12:13           ` Greg KH [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191011121300.GA1144378@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=stable@vger.kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Stable Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://lore.kernel.org/stable \
		stable@vger.kernel.org
	public-inbox-index stable

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git