From: Sebastian Reichel <sre@kernel.org>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH v1] power: supply: ltc2941-battery-gauge: fix use-after-free
Date: Sun, 20 Oct 2019 23:15:53 +0200 [thread overview]
Message-ID: <20191020211553.cjfdpvhyqilhsbh4@earth.universe> (raw)
In-Reply-To: <20190919151137.9960-1-TheSven73@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]
Hi,
On Thu, Sep 19, 2019 at 11:11:37AM -0400, Sven Van Asbroeck wrote:
> This driver's remove path calls cancel_delayed_work().
> However, that function does not wait until the work function
> finishes. This could mean that the work function is still
> running after the driver's remove function has finished,
> which would result in a use-after-free.
>
> Fix by calling cancel_delayed_work_sync(), which ensures that
> that the work is properly cancelled, no longer running, and
> unable to re-schedule itself.
>
> This issue was detected with the help of Coccinelle.
>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/ltc2941-battery-gauge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/ltc2941-battery-gauge.c b/drivers/power/supply/ltc2941-battery-gauge.c
> index da49436176cd..30a9014b2f95 100644
> --- a/drivers/power/supply/ltc2941-battery-gauge.c
> +++ b/drivers/power/supply/ltc2941-battery-gauge.c
> @@ -449,7 +449,7 @@ static int ltc294x_i2c_remove(struct i2c_client *client)
> {
> struct ltc294x_info *info = i2c_get_clientdata(client);
>
> - cancel_delayed_work(&info->work);
> + cancel_delayed_work_sync(&info->work);
> power_supply_unregister(info->supply);
> return 0;
> }
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-10-20 21:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 15:11 [PATCH v1] power: supply: ltc2941-battery-gauge: fix use-after-free Sven Van Asbroeck
[not found] ` <20190919182904.AF657207FC@mail.kernel.org>
2019-09-19 18:58 ` Sven Van Asbroeck
2019-09-19 19:02 ` [PATCH 4.4 " Sven Van Asbroeck
2019-12-02 18:43 ` Greg KH
2019-12-02 19:59 ` Sven Van Asbroeck
2020-02-07 8:51 ` Greg KH
2019-10-20 21:15 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191020211553.cjfdpvhyqilhsbh4@earth.universe \
--to=sre@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).