From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A380FCA9EBD for ; Sun, 27 Oct 2019 21:15:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A09B214E0 for ; Sun, 27 Oct 2019 21:15:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210920; bh=Btr509zcY8sglwO9PqXNHTttCMolbSlE3k5KFWWtbpQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wVpBI3i3xde0TdDXbsHmjSmVZA1Ac3Q6h5+taY2tCbwSpK8T3L8vE5LBCtONUKqgq sIHTgEv1myYNpjxXYuTzccOxch0gDjJDeqrg+SrM+7qJVd3R6VwNm6XEuTznsHJOxd 8ihIEGRjZENPm3lfg6YaLIiK0kHhPxa6T9URgiIY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730628AbfJ0VPT (ORCPT ); Sun, 27 Oct 2019 17:15:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:34272 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730591AbfJ0VPH (ORCPT ); Sun, 27 Oct 2019 17:15:07 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 34036214AF; Sun, 27 Oct 2019 21:15:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572210906; bh=Btr509zcY8sglwO9PqXNHTttCMolbSlE3k5KFWWtbpQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MlLpcd1EyWe/oYNpgEVB50E8XHsuyaI8OFuG5ii6J+7oKO7wLehUv7RNZp1p1Urxv b7tHUEBb7anQytWGDFE6LgNvg5tbJQBCWmyO/1wCwb5aXeOYKl6HcSrjDaT1l6sHU2 8WqfnVETs72NDOgK0t8vfDNKpIkWG91sd8P6ugNc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , "David S. Miller" Subject: [PATCH 4.19 31/93] net/ibmvnic: Fix EOI when running in XIVE mode. Date: Sun, 27 Oct 2019 22:00:43 +0100 Message-Id: <20191027203257.252862748@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203251.029297948@linuxfoundation.org> References: <20191027203251.029297948@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: "Cédric Le Goater" [ Upstream commit 11d49ce9f7946dfed4dcf5dbde865c78058b50ab ] pSeries machines on POWER9 processors can run with the XICS (legacy) interrupt mode or with the XIVE exploitation interrupt mode. These interrupt contollers have different interfaces for interrupt management : XICS uses hcalls and XIVE loads and stores on a page. H_EOI being a XICS interface the enable_scrq_irq() routine can fail when the machine runs in XIVE mode. Fix that by calling the EOI handler of the interrupt chip. Fixes: f23e0643cd0b ("ibmvnic: Clear pending interrupt after device reset") Signed-off-by: Cédric Le Goater Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/ibm/ibmvnic.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -2731,12 +2731,10 @@ static int enable_scrq_irq(struct ibmvni if (adapter->resetting && adapter->reset_reason == VNIC_RESET_MOBILITY) { - u64 val = (0xff000000) | scrq->hw_irq; + struct irq_desc *desc = irq_to_desc(scrq->irq); + struct irq_chip *chip = irq_desc_get_chip(desc); - rc = plpar_hcall_norets(H_EOI, val); - if (rc) - dev_err(dev, "H_EOI FAILED irq 0x%llx. rc=%ld\n", - val, rc); + chip->irq_eoi(&desc->irq_data); } rc = plpar_hcall_norets(H_VIOCTL, adapter->vdev->unit_address,