From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 396C3CA9ED4 for ; Mon, 4 Nov 2019 22:29:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F30282080F for ; Mon, 4 Nov 2019 22:29:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572906542; bh=jyF5xvHleVqHoDq1jqSXHLNhomG/nNLLQWgXo2emWoQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JAO+RRbGCovgcWEvjUc1ASYufsMEeXz+x1mU0YqGYFGEdrkAL8AMDqTG578sxL6AD uai8v7FI7PtyQ5TyPeQ+8VGuC1HZsKNu21e3RHWxfyRMClF7yr18sULB1iHfwk9Uul HswLVl0FM+q/gDN22dvptCQ2DP/sme8iSa6+3pVc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729996AbfKDVsW (ORCPT ); Mon, 4 Nov 2019 16:48:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:38644 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729968AbfKDVsV (ORCPT ); Mon, 4 Nov 2019 16:48:21 -0500 Received: from localhost (6.204-14-84.ripe.coltfrance.com [84.14.204.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D1FB7214E0; Mon, 4 Nov 2019 21:48:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572904101; bh=jyF5xvHleVqHoDq1jqSXHLNhomG/nNLLQWgXo2emWoQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EkLHJhvSQDZOLDj9fC5vtFsRgMKL8ZP7Xw3O9xY26XT8bgUv46M7qKKkCZsZ8AUw0 y6U5SEoZSrufppK2l8Raz2ywXze9VwckeGPdydUgLkiWRE9ExvKRC34eBFmRNPpetB p6M43hUslHV4RaKj2MiwhtRCXXDAEPdFVB+h7uZQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Johan Hovold , Sasha Levin Subject: [PATCH 4.4 22/46] USB: legousbtower: fix a signedness bug in tower_probe() Date: Mon, 4 Nov 2019 22:44:53 +0100 Message-Id: <20191104211851.842474634@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191104211830.912265604@linuxfoundation.org> References: <20191104211830.912265604@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit fd47a417e75e2506eb3672ae569b1c87e3774155 ] The problem is that sizeof() is unsigned long so negative error codes are type promoted to high positive values and the condition becomes false. Fixes: 1d427be4a39d ("USB: legousbtower: fix slab info leak at probe") Signed-off-by: Dan Carpenter Acked-by: Johan Hovold Link: https://lore.kernel.org/r/20191011141115.GA4521@mwanda Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/misc/legousbtower.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -910,7 +910,7 @@ static int tower_probe (struct usb_inter get_version_reply, sizeof(*get_version_reply), 1000); - if (result < sizeof(*get_version_reply)) { + if (result != sizeof(*get_version_reply)) { if (result >= 0) result = -EIO; dev_err(idev, "get version request failed: %d\n", result);