From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC3E7CA9EC9 for ; Mon, 4 Nov 2019 22:28:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE23E214D8 for ; Mon, 4 Nov 2019 22:28:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572906497; bh=2WJRi8DP8DqGTf6NYmHpPXfIjADbeGfQXHFPy3YFDgg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ERVMLOHCT+J/lVrY5D/Jf+CBY9qr1NrjjL8YipHpozlPMLlz17EzRE2QhwIn7IUKO /g6/Uo3/3KpiO7hdUPFwdXbyWvtyQQBrC2iHBdbiM2PjgZFAJPXxKoI/Lq2IfEw9/W VNvcc4ltVqFuVjokryGOCBEvjjwhMIO4+a8T6l/M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730318AbfKDVtU (ORCPT ); Mon, 4 Nov 2019 16:49:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:40548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730337AbfKDVtT (ORCPT ); Mon, 4 Nov 2019 16:49:19 -0500 Received: from localhost (6.204-14-84.ripe.coltfrance.com [84.14.204.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7428E20B7C; Mon, 4 Nov 2019 21:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572904158; bh=2WJRi8DP8DqGTf6NYmHpPXfIjADbeGfQXHFPy3YFDgg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dyQk7lAJV9gn5gN+Lhi3saKJGpu7vLT482k/sZoN6ssQQd62JQYOyaAB/2Icl9sE1 q6TFyUcL9J6kZKpQYySe/HQ2/mJgmA1jpxOEln5XL4lcWP4HkK923LxVMdz894LLyB EvAlWBvdPDP1TOLiEQkuEof6QCa6STFqBmhETgTc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold Subject: [PATCH 4.4 32/46] USB: serial: whiteheat: fix potential slab corruption Date: Mon, 4 Nov 2019 22:45:03 +0100 Message-Id: <20191104211906.870415903@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191104211830.912265604@linuxfoundation.org> References: <20191104211830.912265604@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Johan Hovold commit 1251dab9e0a2c4d0d2d48370ba5baa095a5e8774 upstream. Fix a user-controlled slab buffer overflow due to a missing sanity check on the bulk-out transfer buffer used for control requests. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable Signed-off-by: Johan Hovold Link: https://lore.kernel.org/r/20191029102354.2733-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/whiteheat.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/usb/serial/whiteheat.c +++ b/drivers/usb/serial/whiteheat.c @@ -604,6 +604,10 @@ static int firm_send_command(struct usb_ command_port = port->serial->port[COMMAND_PORT]; command_info = usb_get_serial_port_data(command_port); + + if (command_port->bulk_out_size < datasize + 1) + return -EIO; + mutex_lock(&command_info->mutex); command_info->command_finished = false;