From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1610CA9EC9 for ; Mon, 4 Nov 2019 22:15:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACF9E204EC for ; Mon, 4 Nov 2019 22:15:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572905720; bh=/bed9kQ9wctSWQIEVWMoM3vLii4+hyghZGfFJWUIRk8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GtaVE6Kpew5aNZoFuG+qDsVWnqOIIb1NKHb3WzXIsWV6cUjGUn/XiiETlJUFzy81z xDW3Dr9Fy8Dyw1LKViJa8XL0DU0h1kRXaUzW0TsNaNMomTSi3SBtfPzxfDX8mmibog qvEpR9vZRmKOYOffo4jEOQeDLph2+Wko2LiUKRck= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388928AbfKDWGL (ORCPT ); Mon, 4 Nov 2019 17:06:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:37876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389917AbfKDWGK (ORCPT ); Mon, 4 Nov 2019 17:06:10 -0500 Received: from localhost (6.204-14-84.ripe.coltfrance.com [84.14.204.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EB2DC20650; Mon, 4 Nov 2019 22:06:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572905169; bh=/bed9kQ9wctSWQIEVWMoM3vLii4+hyghZGfFJWUIRk8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LbDKDqgVJKlSuwoxRkatk3weSk7B01giHoyIuu22sQYM3BIJbikKHlDcEoer7X5VV YF/wcenRUpVG6i3hS75fXveTFKezzgdPrOqt9vSQEJWSI2fJ1qVn/933QAkIiV8YZO bkAMKhsWCum0883zZi+EQgWb1xNLgZVmFh1Q+lsk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Russell King - ARM Linux admin , Adrian Hunter , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Will Deacon , Arnaldo Carvalho de Melo , Sasha Levin , Peter Zijlstra Subject: [PATCH 5.3 014/163] perf annotate: Propagate perf_env__arch() error Date: Mon, 4 Nov 2019 22:43:24 +0100 Message-Id: <20191104212141.482686941@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191104212140.046021995@linuxfoundation.org> References: <20191104212140.046021995@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnaldo Carvalho de Melo [ Upstream commit a66fa0619a0ae3585ef09e9c33ecfb5c7c6cb72b ] The callers of symbol__annotate2() use symbol__strerror_disassemble() to convert its failure returns into a human readable string, so propagate error values from functions it calls, starting with perf_env__arch() that when fails the right thing to do is to look at 'errno' to see why its possible call to uname() failed. Reported-by: Russell King - ARM Linux admin Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra , Cc: Will Deacon Link: https://lkml.kernel.org/n/tip-it5d83kyusfhb1q1b0l4pxzs@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/annotate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index 163536720149b..6d9642c082e52 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -2065,7 +2065,7 @@ int symbol__annotate(struct symbol *sym, struct map *map, int err; if (!arch_name) - return -1; + return errno; args.arch = arch = arch__find(arch_name); if (arch == NULL) -- 2.20.1