From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E735CA9EC9 for ; Mon, 4 Nov 2019 22:14:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4DCF214E0 for ; Mon, 4 Nov 2019 22:14:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572905671; bh=5VyfATjDRZ/d61SscXopb+AgGGmd7/YaQZLg5GFAo3w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=gRzv5Xq82j25IsieH+/WWowOUOmwBDCdbXpfjVbLoqIKuDLo5pPyG25s1RKIYaJWg sF96RkjTuz9Dvrm9C0gAaTcYe6Coe3rD6WfVmTt7+Kkf0X6Kf1unh+Ce03q8nrd49y Slu6w0aRZvZdNHpv0m5sxnIYlIwpAZfv1flCiEHg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389149AbfKDWHs (ORCPT ); Mon, 4 Nov 2019 17:07:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:40470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390030AbfKDWHs (ORCPT ); Mon, 4 Nov 2019 17:07:48 -0500 Received: from localhost (6.204-14-84.ripe.coltfrance.com [84.14.204.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C5D5221D7D; Mon, 4 Nov 2019 22:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572905266; bh=5VyfATjDRZ/d61SscXopb+AgGGmd7/YaQZLg5GFAo3w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rYg9TqzQYjeZzq1WycnALZxQj6zqVkj2jt3NITVSpBdgHF6WLnwl/s0Z5t+s2+vRC zGj//kv88koNMDSJN4QgMYgSyiaJwABsEZhpdOXZxEeaNhAjMAn8UYsv/apizdUB7d XXZgjhynKXxXGujlnivCCZttCcDMmScatsivbarY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Johan Hovold , Sasha Levin Subject: [PATCH 5.3 085/163] USB: legousbtower: fix a signedness bug in tower_probe() Date: Mon, 4 Nov 2019 22:44:35 +0100 Message-Id: <20191104212146.412986855@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191104212140.046021995@linuxfoundation.org> References: <20191104212140.046021995@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit fd47a417e75e2506eb3672ae569b1c87e3774155 ] The problem is that sizeof() is unsigned long so negative error codes are type promoted to high positive values and the condition becomes false. Fixes: 1d427be4a39d ("USB: legousbtower: fix slab info leak at probe") Signed-off-by: Dan Carpenter Acked-by: Johan Hovold Link: https://lore.kernel.org/r/20191011141115.GA4521@mwanda Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/misc/legousbtower.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index 62dab2441ec4f..23061f1526b4e 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -878,7 +878,7 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device get_version_reply, sizeof(*get_version_reply), 1000); - if (result < sizeof(*get_version_reply)) { + if (result != sizeof(*get_version_reply)) { if (result >= 0) result = -EIO; dev_err(idev, "get version request failed: %d\n", result); -- 2.20.1