From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFACDCA9EC9 for ; Mon, 4 Nov 2019 22:13:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BACA20650 for ; Mon, 4 Nov 2019 22:13:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572905606; bh=NQVZ6s6H1xwJK/ZO3ammWuvgpSD8GLRnPoedXMtSxMU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2bRczzG9PBmKzJTLjopmw8YYf3l5xYZKJJ6yoGHi6QPbkBjTqEhsh33GZHPjJNtAG huucl2Fm4vaOL/fh74i0E2X41kVXUxucFYN8LHWTBzBr1F07HT19qtv0htxKBFl0kV 4OXgpEIdTTurl2l/mmhnnAQ8VwGKye3EfTpJ5lD4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389393AbfKDWKD (ORCPT ); Mon, 4 Nov 2019 17:10:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:43190 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387458AbfKDWKC (ORCPT ); Mon, 4 Nov 2019 17:10:02 -0500 Received: from localhost (6.204-14-84.ripe.coltfrance.com [84.14.204.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19AC7205C9; Mon, 4 Nov 2019 22:10:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572905401; bh=NQVZ6s6H1xwJK/ZO3ammWuvgpSD8GLRnPoedXMtSxMU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YpoH09B0j00nEc/PeBYy9ueWcoGye/fNplbxwz7nXN9Cs4nJFHVJyizcMd4JtRBcu kpPRna97mTqn8oUUJR41+iXNRPCVbceqZXZDsU2YK3+nQO/PmfjFw1DBCPc4CAQ3MV GoVtea/CPNgGkLrQ3Yhb3tXBmkiac7ep3u8zW1Cw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nicolas Waisman , Laura Abbott , Ping-Ke Shih , Kalle Valo Subject: [PATCH 5.3 131/163] rtlwifi: Fix potential overflow on P2P code Date: Mon, 4 Nov 2019 22:45:21 +0100 Message-Id: <20191104212149.821168769@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191104212140.046021995@linuxfoundation.org> References: <20191104212140.046021995@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Laura Abbott commit 8c55dedb795be8ec0cf488f98c03a1c2176f7fb1 upstream. Nicolas Waisman noticed that even though noa_len is checked for a compatible length it's still possible to overrun the buffers of p2pinfo since there's no check on the upper bound of noa_num. Bound noa_num against P2P_MAX_NOA_NUM. Reported-by: Nicolas Waisman Signed-off-by: Laura Abbott Acked-by: Ping-Ke Shih Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/realtek/rtlwifi/ps.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/net/wireless/realtek/rtlwifi/ps.c +++ b/drivers/net/wireless/realtek/rtlwifi/ps.c @@ -754,6 +754,9 @@ static void rtl_p2p_noa_ie(struct ieee80 return; } else { noa_num = (noa_len - 2) / 13; + if (noa_num > P2P_MAX_NOA_NUM) + noa_num = P2P_MAX_NOA_NUM; + } noa_index = ie[3]; if (rtlpriv->psc.p2p_ps_info.p2p_ps_mode == @@ -848,6 +851,9 @@ static void rtl_p2p_action_ie(struct iee return; } else { noa_num = (noa_len - 2) / 13; + if (noa_num > P2P_MAX_NOA_NUM) + noa_num = P2P_MAX_NOA_NUM; + } noa_index = ie[3]; if (rtlpriv->psc.p2p_ps_info.p2p_ps_mode ==