stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Cc: stable@vger.kernel.org, vkoul@kernel.org
Subject: Re: [PATCH][STABLE backport 4.14/4.9] dmaengine: qcom: bam_dma: Fix resource leak
Date: Fri, 8 Nov 2019 13:53:25 +0100	[thread overview]
Message-ID: <20191108125325.GA738452@kroah.com> (raw)
In-Reply-To: <20191105201442.12477-1-jeffrey.l.hugo@gmail.com>

On Tue, Nov 05, 2019 at 12:14:42PM -0800, Jeffrey Hugo wrote:
> Commit 7667819385457b4aeb5fac94f67f52ab52cc10d5 upstream.
> 
> bam_dma_terminate_all() will leak resources if any of the transactions are
> committed to the hardware (present in the desc fifo), and not complete.
> Since bam_dma_terminate_all() does not cause the hardware to be updated,
> the hardware will still operate on any previously committed transactions.
> This can cause memory corruption if the memory for the transaction has been
> reassigned, and will cause a sync issue between the BAM and its client(s).
> 
> Fix this by properly updating the hardware in bam_dma_terminate_all().
> 
> Fixes: e7c0fe2a5c84 ("dmaengine: add Qualcomm BAM dma driver")
> Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> Cc: stable@vger.kernel.org
> Link: https://lore.kernel.org/r/20191017152606.34120-1-jeffrey.l.hugo@gmail.com
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> Backported to 4.14 which is lacking 6b4faeac05bc
> ("dmaengine: qcom-bam: Process multiple pending descriptors")
> This version also applies to 4.9.

Thanks for this and the 4.4 backport, all now queued up.

greg k-h

      reply	other threads:[~2019-11-08 12:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 20:14 [PATCH][STABLE backport 4.14/4.9] dmaengine: qcom: bam_dma: Fix resource leak Jeffrey Hugo
2019-11-08 12:53 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191108125325.GA738452@kroah.com \
    --to=greg@kroah.com \
    --cc=jeffrey.l.hugo@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).