From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84B9DFA372C for ; Fri, 8 Nov 2019 19:03:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52B562067B for ; Fri, 8 Nov 2019 19:03:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573239818; bh=ffIQ5dJGnYJzi9DjSzvkcNshyzB7rOklGtY+nCx3KnY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=sbUH52O7ODfcOhvCLrFlKsa2TdIowka+GYpsTCcYXeUpWAsgWTLFCvOwoD/UqajjZ 5N0XSNV16XOfIpc6QHo4iTu7Nwo6MUe21QmvEunx2ICO80AlR6AmXo5ebXC7v0uSTz Cr2xSlngjLkP6XahcRBNDG+DbjeA/xN2LSy2QANs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389085AbfKHTDh (ORCPT ); Fri, 8 Nov 2019 14:03:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:33256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390801AbfKHTDe (ORCPT ); Fri, 8 Nov 2019 14:03:34 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 45DD62067B; Fri, 8 Nov 2019 19:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573239813; bh=ffIQ5dJGnYJzi9DjSzvkcNshyzB7rOklGtY+nCx3KnY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n6GSJrS979VgHpHq7LUbjvzpxLcvMwm9aAB5pmz5VC6a3dwrTZBsPnOmkaoMBXjrQ 0Rhc+1ORglvuZRGfrksomBQniF+nvh4j3Ddrri2l4yIZ2Tenvojunzw0RgWB/tpiVa 8sv+eDMf2SialQGdbK17zsrIcRgvQIF/z7zCtrOc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vivien Didelot , Florian Fainelli , "David S. Miller" Subject: [PATCH 4.19 69/79] net: dsa: fix switch tree list Date: Fri, 8 Nov 2019 19:50:49 +0100 Message-Id: <20191108174823.875664780@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191108174745.495640141@linuxfoundation.org> References: <20191108174745.495640141@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vivien Didelot [ Upstream commit 50c7d2ba9de20f60a2d527ad6928209ef67e4cdd ] If there are multiple switch trees on the device, only the last one will be listed, because the arguments of list_add_tail are swapped. Fixes: 83c0afaec7b7 ("net: dsa: Add new binding implementation") Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/dsa/dsa2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/dsa/dsa2.c +++ b/net/dsa/dsa2.c @@ -49,7 +49,7 @@ static struct dsa_switch_tree *dsa_tree_ dst->index = index; INIT_LIST_HEAD(&dst->list); - list_add_tail(&dsa_tree_list, &dst->list); + list_add_tail(&dst->list, &dsa_tree_list); kref_init(&dst->refcount);