From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E0CC5DF60 for ; Fri, 8 Nov 2019 19:15:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83FAC20650 for ; Fri, 8 Nov 2019 19:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573240523; bh=dyWpOrS8kPblaluBAYmqNzbntvaVnGy7CHkLumzzqAY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=p+slnyfJH9cE9V64OAL88I91Up82OCToXaJiLtuNjEnY/AJkXLttlCu51Dh/MCNhI JzwrPzAoPlv8Jwm8Fjf2THtqU5iBGBXGuprPg7xDCBEn44/XNCbh/hitYs7vUWrGEc FF+Cp2Vmdkh8BUoQ2pyN/bBHpiS7LAlq8EOM1JZk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391121AbfKHTFT (ORCPT ); Fri, 8 Nov 2019 14:05:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:35458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388375AbfKHTFS (ORCPT ); Fri, 8 Nov 2019 14:05:18 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0521A218AE; Fri, 8 Nov 2019 19:05:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573239918; bh=dyWpOrS8kPblaluBAYmqNzbntvaVnGy7CHkLumzzqAY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R9ZYCjAukt9XCdiOtqgRy5nmH89MBLSwvRRuLqAe4TNqA0pRo7dJXVXg8iX0j8018 Pfr85m4bNzelFk2r3HwHor1L+AzZzExGNzLDU66S+HFGWGYaXyGxaf3KLE6sUL3Sad auuZRYYnFH2PwZV8NKm7wvnXH4jFMX9ZC5eg+kSw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Mark Brown , Sasha Levin Subject: [PATCH 5.3 005/140] ASoC: topology: Fix a signedness bug in soc_tplg_dapm_widget_create() Date: Fri, 8 Nov 2019 19:48:53 +0100 Message-Id: <20191108174900.650765622@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191108174900.189064908@linuxfoundation.org> References: <20191108174900.189064908@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit 752c938a5c14b8cbf0ed3ffbfa637fb166255c3f ] The "template.id" variable is an enum and in this context GCC will treat it as an unsigned int so it can never be less than zero. Fixes: 8a9782346dcc ("ASoC: topology: Add topology core") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20190925110624.GR3264@mwanda Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/soc-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index dc463f1a9e242..1cc5a07a2f5c7 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -1588,7 +1588,7 @@ static int soc_tplg_dapm_widget_create(struct soc_tplg *tplg, /* map user to kernel widget ID */ template.id = get_widget_id(le32_to_cpu(w->id)); - if (template.id < 0) + if ((int)template.id < 0) return template.id; /* strings are allocated here, but used and freed by the widget */ -- 2.20.1