From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7577C17440 for ; Sun, 10 Nov 2019 03:09:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3481208C3 for ; Sun, 10 Nov 2019 03:09:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573355371; bh=J7af8Qtw38Ew9P8n51YmBy+yIcLcxX26TQGIZ7m712s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rYCC1naHCzl0YjhnaQvK3mDJstFHQNtnjPOqOFa7/Fs3J+ZbjsF4vPZc/P87TBObs 4fLgPgs85Kjp8yu1g9r3FdghdW2y+K/DTHUFa+kzmovX7UMS/X7LFYT2lESh8RQ2VU hu3R5nFmaGWBoOLP8n5jFPZuVGbvqemntubhZ9oc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728594AbfKJCog (ORCPT ); Sat, 9 Nov 2019 21:44:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:44100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728592AbfKJCof (ORCPT ); Sat, 9 Nov 2019 21:44:35 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F9D421D82; Sun, 10 Nov 2019 02:44:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573353874; bh=J7af8Qtw38Ew9P8n51YmBy+yIcLcxX26TQGIZ7m712s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VteY9gRcnJY2TuewLGeTHaOEOURGNqqjxMSNrn0zcRU03ZLPzWSMQMXZ1JIYbKzmj P7huH+GL+8Br/N6J/wtHNsvBff3L3bPSKbp/VbUzlH3N0vHJ4QTulK+zuFvros8Ngd 5CZqkPJKkm/Tb/xxrBY4HioMNlKJzjkCiJT8HL0o= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Balakrishna Godavarthi , Marcel Holtmann , Sasha Levin , linux-bluetooth@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 153/191] Bluetooth: hci_serdev: clear HCI_UART_PROTO_READY to avoid closing proto races Date: Sat, 9 Nov 2019 21:39:35 -0500 Message-Id: <20191110024013.29782-153-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191110024013.29782-1-sashal@kernel.org> References: <20191110024013.29782-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Balakrishna Godavarthi [ Upstream commit 7cf7846d27bfc9731e449857db3eec5e0e9701ba ] Clearing HCI_UART_PROTO_READY will avoid usage of proto function pointers before running the proto close function pointer. There is chance of kernel crash, due to usage of non proto close function pointers after proto close. Signed-off-by: Balakrishna Godavarthi Signed-off-by: Marcel Holtmann Signed-off-by: Sasha Levin --- drivers/bluetooth/hci_serdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c index aa2543b3c2869..46e20444ba19b 100644 --- a/drivers/bluetooth/hci_serdev.c +++ b/drivers/bluetooth/hci_serdev.c @@ -368,6 +368,7 @@ void hci_uart_unregister_device(struct hci_uart *hu) { struct hci_dev *hdev = hu->hdev; + clear_bit(HCI_UART_PROTO_READY, &hu->flags); hci_unregister_dev(hdev); hci_free_dev(hdev); -- 2.20.1